This repository was archived by the owner on Oct 10, 2023. It is now read-only.
Conversation
DS-237 Document how to describe package requirement inputs
With DS-209 we got the ability to embed package requirements into Cargo.toml files. Let's start building out the documentation for the tool by describing how to do this for your own crate. |
Hoverbear
reviewed
Aug 19, 2022
grahamc
approved these changes
Aug 19, 2022
Member
|
Is this still a draft / @Hoverbear what do you think about using the link to the install page? |
cole-h
commented
Aug 22, 2022
|
|
||
| * `build-inputs`, which are native dependencies that the crate may want to link against. | ||
| * `environment-variables`, which are environment variables you may want to set in your dev shell. | ||
| * `runtime-inputs`, which are libraries you may want to add to your `LD_LIBRARY_PATH` to ensure proper execution in your dev shell. |
Member
Author
There was a problem hiding this comment.
Slightly reworded, since I realized that LD_LIBRARY_PATH isn't for linking (commonly meaning "linking during the build in order to produce a binary"), but more for execution of the built binary.
Contributor
There was a problem hiding this comment.
I think that this term is nice.
Hoverbear
approved these changes
Aug 22, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting on the discussion at #28 (comment) to come to a conclusion so I can update the names.