Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

pass through $SHELL#205

Merged
cole-h merged 1 commit intoDeterminateSystems:mainfrom
figsoda:shell
Jan 11, 2023
Merged

pass through $SHELL#205
cole-h merged 1 commit intoDeterminateSystems:mainfrom
figsoda:shell

Conversation

@figsoda
Copy link
Copy Markdown
Contributor

@figsoda figsoda commented Jan 11, 2023

NixOS/nix@27be54c

this fixes the issue where my prompt (fish + starship) gets jumbled up if I riff shell in a riff shell

before:

~/riff on  main 
❯ result/bin/riff shell
✓ 🦀 rust: cargo, openssl, pkg-config, rustc, rustfmt

~/riff on  main via  impure (riff-shell) 
❯ result/bin/riff shell
✓ 🦀 rust: cargo, openssl, pkg-config, rustc, rustfmt

\[\]~/riff\[\] on \[\] \[\]\[\]main\[\] via \[\] \[\]\[\]impure\[\]\[\] (\[\]\[\]riff-shell\[\]\[\])\[\] 
\[\]❯\[\]

after:

~/riff on  shell 
❯ result/bin/riff shell
✓ 🦀 rust: cargo, openssl, pkg-config, rustc, rustfmt

~/riff on  shell via  impure (riff-shell) 
❯ result/bin/riff shell
✓ 🦀 rust: cargo, openssl, pkg-config, rustc, rustfmt

~/riff on  shell via  impure (riff-shell) 
❯

cole-h
cole-h approved these changes Jan 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.

@cole-h cole-h merged commit 6085884 into DeterminateSystems:main Jan 11, 2023
@figsoda figsoda deleted the shell branch January 11, 2023 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cole-h cole-h cole-h approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@figsoda @cole-h