This repository was archived by the owner on Oct 10, 2023. It is now read-only.
Draft
Conversation
This was referenced Oct 12, 2022
1eba9f7 to
595b956
Compare
We require users to have installed `cargo` (typically done via `rustup`), which includes `rustc`, `cargo`, and `rustfmt` by default. We could recommend `rustup` directly (e.g. instead of any distro package) in order to easily support the `rust-toolchain.toml` file that may or may not exist in any given project.
…oml files by default
595b956 to
81d1243
Compare
Hoverbear
approved these changes
Oct 12, 2022
Member
Author
|
Drafted because it's come up that this isn't the ideal solution (because |
Contributor
|
I opened #200 as an alternative |
Contributor
|
after thinking about it, I think this might be a better solution since we already need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We require users to have installed
cargo(typically done viarustup), which includesrustc,cargo, andrustfmtby default.Fixes #147.
Maybe fixes #126.
In order to test this PR, there are a few things you need to do (as a result of our remote registry):
nix buildwill suffice, but you could also bootstrap with Riff itself andriff run cargo build), or download one of the pre-compiled binaries from buildkite or GitHub Actions (aarch64-linux binaries available on request but they are not currently automated)rm ~/.cache/riff/registry.jsoncargo metadatato ensure cargo doesn't need to download any dependencies (because the next command will run allcargocommands in offline mode)--offlineflag, e.g.:riff shell --offlineand verify thatrustc,cargo, andrustfmtdo not show up in the list of dependencies Riff added to the shellNote that, if at any point you use Riff without the
--offlineflag, you will need to repeat step 1 and remove the cached registry.