This repository was archived by the owner on Oct 10, 2023. It is now read-only.
Ensure distinct_id can't get leaked on accident#119
Merged
Conversation
We do this by using the secrecy crate to ensure the `fmt::Debug` representation of the Telemetry struct redacts the distinct_id field.
Member
|
Looking good: |
grahamc
approved these changes
Sep 8, 2022
Member
|
Note I also verified that the telemetry events still contain the distinct ID as expected. Nicely done! |
Hoverbear
approved these changes
Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do this by using the secrecy crate to ensure the
fmt::Debugrepresentation of the Telemetry struct redacts the distinct_id field.Because
Uuidis a foreign type, I had to make a newtype around it in order to implement the marker traits that allowssecrecy::Secretto do its job.