LocalStore::addToStore(): Reinstate try/catch

edolstra · edolstra · commit 15efebdb00af · 2025-10-23T16:36:07.000+02:00
`skip()` can throw an exception, which we need to ignore since we may
be unwinding an exception.
diff --git a/src/libstore/local-store.cc b/src/libstore/local-store.cc
@@ -1049,7 +1049,12 @@ void LocalStore::addToStore(const ValidPathInfo & info, Source & source, RepairF
         bool narRead = false;
         Finally cleanup = [&]() {
             if (!narRead)
-                source.skip(info.narSize);
+                try {
+                    source.skip(info.narSize);
+                } catch (...) {
+                    // TODO: should Interrupted be handled here?
+                    ignoreExceptionInDestructor();
+                }
         };
 
         addTempRoot(info.path);
