Skip to content

Clippy nits while hacking around#737

Merged
grahamc merged 4 commits intomainfrom
clippy-nits
Nov 22, 2023
Merged

Clippy nits while hacking around#737
grahamc merged 4 commits intomainfrom
clippy-nits

Conversation

@grahamc
Copy link
Copy Markdown
Member

@grahamc grahamc commented Nov 22, 2023

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@grahamc grahamc marked this pull request as ready for review November 22, 2023 17:27
@cole-h
Copy link
Copy Markdown
Member

cole-h commented Nov 22, 2023

Should we add clippy to CI so that we don't regress here?

@Hoverbear
Copy link
Copy Markdown
Contributor

@cole-h it's already run in lints.

@Hoverbear Hoverbear added this to the 0.15.2 milestone Nov 22, 2023
@grahamc
Copy link
Copy Markdown
Member Author

grahamc commented Nov 22, 2023

How did we regress then? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants