Skip to content

Retry streams#63

Merged
grahamc merged 1 commit intomainfrom
retry-streams
Sep 4, 2024
Merged

Retry streams#63
grahamc merged 1 commit intomainfrom
retry-streams

Conversation

@grahamc
Copy link
Copy Markdown
Member

@grahamc grahamc commented Sep 4, 2024

Description
Checklist
  • Tested changes against a test repository
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 4, 2024

Deploy Preview for detsys-ts-docs ready!

Name Link
🔨 Latest commit e88434e
🔍 Latest deploy log https://app.netlify.com/sites/detsys-ts-docs/deploys/66d89768ae36820008d1ba1d
😎 Deploy Preview https://deploy-preview-63--detsys-ts-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Streams can't be retried, since we open a destination and write directly to it.
Retrying the stream involves an error handler that supports resetting the stream and starting over.

This implements that.

Also:

1. Ensure we retry at least three times, regardless of how many backends are available
2. Record timings and URL information from timeout errors
3. Clean up recordEvent to not allow complex types in values to match the backend
@grahamc grahamc merged commit 65dd73c into main Sep 4, 2024
@grahamc grahamc deleted the retry-streams branch September 4, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants