Drop the old schemas and integrate the open PRs by grahamc · Pull Request #162 · DeterminateSystems/detsys-ts

grahamc · 2026-03-24T22:16:58Z

Description

CI was failing because of the schemas change

Checklist

Tested changes against a test repository
Added or updated relevant documentation (leave unchecked if not applicable)
(If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)

Summary by CodeRabbit

Chores
- Removed an external flake dependency to simplify the build footprint.
- Updated several development and build-related package versions (linting, types, testing, and documentation tooling) to their newer releases.

Bumps [undici](https://github.com/nodejs/undici) from 6.23.0 to 6.24.1. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v6.23.0...v6.24.1) --- updated-dependencies: - dependency-name: undici dependency-version: 6.24.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [flatted](https://github.com/WebReflection/flatted) from 3.3.3 to 3.4.2. - [Commits](WebReflection/flatted@v3.3.3...v3.4.2) --- updated-dependencies: - dependency-name: flatted dependency-version: 3.4.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 5.3.6 to 5.5.8. - [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases) - [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md) - [Commits](NaturalIntelligence/fast-xml-parser@v5.3.6...v5.5.8) --- updated-dependencies: - dependency-name: fast-xml-parser dependency-version: 5.5.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [rollup](https://github.com/rollup/rollup) from 4.57.0 to 4.59.1. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.57.0...v4.59.1) --- updated-dependencies: - dependency-name: rollup dependency-version: 4.59.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps the npm-deps group with 8 updates in the / directory: | Package | From | To | | --- | --- | --- | | [type-fest](https://github.com/sindresorhus/type-fest) | `5.4.4` | `5.5.0` | | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `25.2.3` | `25.5.0` | | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `8.55.0` | `8.57.1` | | [eslint](https://github.com/eslint/eslint) | `9.39.2` | `10.1.0` | | [globals](https://github.com/sindresorhus/globals) | `17.3.0` | `17.4.0` | | [tsdown](https://github.com/rolldown/tsdown) | `0.20.3` | `0.21.4` | | [typedoc](https://github.com/TypeStrong/TypeDoc) | `0.28.16` | `0.28.17` | | [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) | `4.0.18` | `4.1.0` | Updates `type-fest` from 5.4.4 to 5.5.0 - [Release notes](https://github.com/sindresorhus/type-fest/releases) - [Commits](sindresorhus/type-fest@v5.4.4...v5.5.0) Updates `@types/node` from 25.2.3 to 25.5.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Updates `@typescript-eslint/eslint-plugin` from 8.55.0 to 8.57.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.57.1/packages/eslint-plugin) Updates `eslint` from 9.39.2 to 10.1.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.2...v10.1.0) Updates `globals` from 17.3.0 to 17.4.0 - [Release notes](https://github.com/sindresorhus/globals/releases) - [Commits](sindresorhus/globals@v17.3.0...v17.4.0) Updates `tsdown` from 0.20.3 to 0.21.4 - [Release notes](https://github.com/rolldown/tsdown/releases) - [Commits](rolldown/tsdown@v0.20.3...v0.21.4) Updates `typedoc` from 0.28.16 to 0.28.17 - [Release notes](https://github.com/TypeStrong/TypeDoc/releases) - [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md) - [Commits](TypeStrong/typedoc@v0.28.16...v0.28.17) Updates `typescript-eslint` from 8.55.0 to 8.57.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.57.1/packages/typescript-eslint) Updates `vitest` from 4.0.18 to 4.1.0 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.0/packages/vitest) --- updated-dependencies: - dependency-name: type-fest dependency-version: 5.5.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: npm-deps - dependency-name: "@types/node" dependency-version: 25.5.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-deps - dependency-name: "@typescript-eslint/eslint-plugin" dependency-version: 8.57.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-deps - dependency-name: eslint dependency-version: 10.1.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm-deps - dependency-name: globals dependency-version: 17.4.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-deps - dependency-name: tsdown dependency-version: 0.21.4 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-deps - dependency-name: typedoc dependency-version: 0.28.17 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-deps - dependency-name: typescript-eslint dependency-version: 8.57.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-deps - dependency-name: vitest dependency-version: 4.1.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-deps ... Signed-off-by: dependabot[bot] <support@github.com>

netlify · 2026-03-24T22:17:12Z

✅ Deploy Preview for detsys-ts-docs ready!

Name	Link
🔨 Latest commit	`35e9185`
🔍 Latest deploy log	https://app.netlify.com/projects/detsys-ts-docs/deploys/69c324a14d51070008021afe
😎 Deploy Preview	https://deploy-preview-162--detsys-ts-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

coderabbitai · 2026-03-24T22:17:13Z

📝 Walkthrough

Walkthrough

Removed the flake-schemas input and its exported schemas output from the Nix flake, and updated several npm dev dependency versions in package.json (including adding @typescript-eslint/parser).

Changes

Cohort / File(s)	Summary
Nix Flake Configuration `flake.nix`	Removed the `flake-schemas` input from `inputs` and deleted `inherit (inputs.flake-schemas) schemas;` from `outputs` (no `schemas` export anymore).
Node package metadata `package.json`	Bumped multiple dev dependency versions (e.g., `type-fest`, `@types/node`, `@typescript-eslint/eslint-plugin`, `vitest`, `typedoc`, `tsdown`, `globals`, `typescript-eslint`) and added `@typescript-eslint/parser` at `^8.57.1`. No script or structural changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

gustavderdrache
cole-h

Poem

🐰 I hopped through flakes and packages bright,
Pruned a schema leaf and tuned versions right,
A parser arrived to join the dance,
Now the build can skip a tiny prance —
Hooray for tidy code and moonlit night! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title 'Drop the old schemas and integrate the open PRs' does not accurately reflect the changeset, which removes the flake-schemas input and updates npm package versions, with no mention of integrating open PRs.	Revise the title to accurately describe the main changes, such as 'Remove flake-schemas dependency and update npm packages' or 'Drop flake-schemas input and bump dependencies'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch push-qmvzspnqmmrx

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

not yet

not yet :P

dependabot bot and others added 6 commits March 14, 2026 09:24

Drop the old schemas

6486b48

cole-h previously approved these changes Mar 24, 2026

View reviewed changes

lucperkins previously approved these changes Mar 24, 2026

View reviewed changes

grahamc requested a review from lucperkins March 24, 2026 22:31

grahamc added 2 commits March 24, 2026 18:32

Fix the package.json to work...

115a2bb

Regenerate

35e9185

grahamc changed the title ~~Drop the old schemas~~ Drop the old schemas and integrate the open PRs Mar 24, 2026

grahamc requested a review from cole-h March 24, 2026 23:59

cole-h approved these changes Mar 25, 2026

View reviewed changes

grahamc merged commit 24d2aa4 into main Mar 25, 2026
6 checks passed

grahamc deleted the push-qmvzspnqmmrx branch March 25, 2026 00:29

grahamc temporarily deployed to detsys-pr-bot March 25, 2026 00:29 — with GitHub Actions Inactive

This was referenced Mar 25, 2026

Update detsys-ts: Drop the old schemas and integrate the open PRs (#162) DeterminateSystems/flake-checker-action#108

Merged

Update detsys-ts: Drop the old schemas and integrate the open PRs (#162) DeterminateSystems/flakehub-push#297

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop the old schemas and integrate the open PRs#162

Drop the old schemas and integrate the open PRs#162
grahamc merged 8 commits intomainfrom
push-qmvzspnqmmrx

grahamc commented Mar 24, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

netlify bot commented Mar 24, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 24, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

grahamc commented Mar 24, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Summary by CodeRabbit

Uh oh!

netlify bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for detsys-ts-docs ready!

Uh oh!

coderabbitai bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

grahamc commented Mar 24, 2026 •

edited by coderabbitai bot

Loading

netlify bot commented Mar 24, 2026 •

edited

Loading

coderabbitai bot commented Mar 24, 2026 •

edited

Loading