Skip complicated rewrites, record groups.#104
Merged
Conversation
…he repository's anon hash as the distinct ID. That was bad modeling.
✅ Deploy Preview for detsys-ts-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cole-h
reviewed
Jul 2, 2025
It used to expect server-side munging, but that caused a ton of problems. This unifies that behavior.
f011601 to
b9bf2cb
Compare
src/index.ts
Outdated
| this.archOs = platform.getArchOs(); | ||
| this.nixSystem = platform.getNixPlatform(this.archOs); | ||
|
|
||
| this.facts["$app_name"] = `${this.actionOptions.name}/action`; |
Contributor
There was a problem hiding this comment.
JS lets us use $ in identifiers, so the quoting isn't needed here.
Suggested change
| this.facts["$app_name"] = `${this.actionOptions.name}/action`; | |
| this.facts.$app_name = `${this.actionOptions.name}/action`; |
Member
Author
There was a problem hiding this comment.
some primal part of my PHP-addled brain HATES this.
gustavderdrache
approved these changes
Jul 3, 2025
This was referenced Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The previous version of this code would do fairly complicated parsing and restructuring server-side. That has been a big mistake. This change makes the manipulation happen client-side and send essentially the direct events we need to send.
One problem is the old method used the repository as the "distinct id" which is not right, and causes confusion between github repos and flakehub users. Now we're using anon distinct IDs which are random, and storing the repository as a group instead.
This also starts tracking the github action name as
$app_namelike we should have been all along.Checklist