Backport: Fix redirect loop when authenticated user is lacking permissions #1386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After successful login, users are redirected to the dashboard. The dashboard requires the `VIEW_PORTFOLIO` permission, and redirects back to the login page if that permission is not present. This could lead to redirect loops for users who lack the permission. Display a popup instead that informs the user about the lack of permissions to proceed. Relates to DependencyTrack/dependency-track#5098 Backports DependencyTrack/hyades-frontend#308 Co-authored-by: Sahiba Mittal <sahiba.mittal@citi.com> Signed-off-by: nscuro <nscuro@protonmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After successful login, users are redirected to the dashboard. The dashboard requires the
VIEW_PORTFOLIOpermission, and redirects back to the login page if that permission is not present. This could lead to redirect loops for users who lack the permission.Display a popup instead that informs the user about the lack of permissions to proceed.
Description
Fixes redirect loop when authenticated user is lacking permissions.
Addressed Issue
Relates to DependencyTrack/dependency-track#5098
Backports #1380
Additional Details
N/A
Checklist
This PR introduces new or alters existing behavior, and I have updated the documentation accordingly