The current a2c_common.py has self.frame >= self.max_frames in the same if with self.epochs >= self.max_epochs
|
if epoch_num >= self.max_epochs or self.frame >= self.max_frames: |
|
if self.game_rewards.current_size == 0: |
|
print('WARNING: Max epochs reached before any env terminated at least once') |
|
mean_rewards = -np.inf |
|
|
|
self.save(os.path.join(self.nn_dir, 'last_' + self.config['name'] + 'ep' + str(epoch_num) + 'rew' + str(mean_rewards))) |
|
print('MAX EPOCHS NUM!') |
It used to be like this https://github.com/ArthurAllshire/rl_games/blob/master/rl_games/common/a2c_common.py#L1243-L1248
The other issue is that when the if condition returns True it always prints MAX EPOCHS NUM! which is not an accurate description because I was running my code and it would print this even when epochs hadn't reached their max. Need to have a separate if condition saying MAX FRAMES NUM!. Though I think what we had earlier is enough and we don't need to add another check on frames.
The current a2c_common.py has
self.frame >= self.max_framesin the same if withself.epochs >= self.max_epochsrl_games/rl_games/common/a2c_common.py
Lines 978 to 984 in d8645b2
It used to be like this https://github.com/ArthurAllshire/rl_games/blob/master/rl_games/common/a2c_common.py#L1243-L1248
The other issue is that when the if condition returns True it always prints
MAX EPOCHS NUM!which is not an accurate description because I was running my code and it would print this even when epochs hadn't reached their max. Need to have a separate if condition sayingMAX FRAMES NUM!. Though I think what we had earlier is enough and we don't need to add another check on frames.