Confirm back action on edit expense screen #748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a confirmation dialog when users attempt to navigate back from the edit expense screen with unsaved changes, preventing accidental data loss. The implementation tracks changes to all expense fields and compares them against the original database values (for existing expenses) or checks for any entered data (for new expenses).
Key changes:
- Added unsaved changes detection logic that compares current form state with database values
- Implemented a BackHandler to intercept back navigation and show a confirmation dialog when changes exist
- Added comprehensive test coverage for various change scenarios (name, price, recurrence, notifications, reminders)
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/libs.versions.toml | Added dependency for compose-ui-backhandler library |
| app/build.gradle.kts | Added compose-ui-backhandler implementation to dependencies |
| EditRecurringExpenseViewModel.kt | Implemented unsaved changes detection, back press handling, and dialog state management |
| EditRecurringExpenseScreen.kt | Integrated BackHandler and added unsaved changes confirmation dialog UI |
| strings.xml | Added English strings for unsaved changes dialog |
| strings-de.xml | Added German translations for unsaved changes dialog |
| EditRecurringExpenseViewModelTest.kt | Added 13 test cases covering unsaved changes detection scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
app/src/commonMain/kotlin/de/dbauer/expensetracker/ui/editexpense/EditRecurringExpenseScreen.kt
Show resolved
Hide resolved
app/src/commonMain/kotlin/de/dbauer/expensetracker/viewmodel/EditRecurringExpenseViewModel.kt
Show resolved
Hide resolved
9848dcf to
535d580
Compare
When creating a new expense or editing an existing one clicking back doesn't require any additional confirmation by the user. This way changes might be lost even though the user wanted to save them. fixes: #746
535d580 to
204fc71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new expense or editing an existing one clicking back doesn't require any additional confirmation by the user. This way changes might be lost even though the user wanted to save them.
fixes: #746