Add option for multiple reminders per expense #740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements multiple reminders per expense functionality, replacing the single notification system with support for multiple configurable reminder intervals. It includes comprehensive data model changes, migration support, and a new UI for managing reminders.
- Replaced single notification fields with a new Reminder entity supporting multiple alerts per expense
- Added database migration from version 8 to 9 with proper foreign key constraints and data preservation
- Introduced new UI components for adding, editing, and removing multiple reminders per expense
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| RecurringExpenseData.kt | Replaced single notification fields with reminders list |
| Reminder.kt | New data class for individual reminder configuration |
| ReminderEntry.kt | Database entity for storing reminder data with foreign key to expenses |
| RecurringExpenseDatabase.kt | Added migration 8→9 creating reminders table and migrating existing data |
| EditRecurringExpenseViewModel.kt | Updated to manage multiple reminders with sorting and validation |
| MultipleRemindersOption.kt | New UI component for managing multiple reminders |
| ExpenseNotificationManager.kt | Updated notification logic to support multiple reminders per expense |
| Various test files | Comprehensive test coverage for new reminder functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.../commonMain/kotlin/de/dbauer/expensetracker/model/notification/ExpenseNotificationManager.kt
Show resolved
Hide resolved
app/src/commonMain/kotlin/de/dbauer/expensetracker/viewmodel/EditRecurringExpenseViewModel.kt
Show resolved
Hide resolved
app/src/commonMain/kotlin/de/dbauer/expensetracker/ui/editexpense/MultipleRemindersOption.kt
Outdated
Show resolved
Hide resolved
app/src/commonMain/kotlin/de/dbauer/expensetracker/viewmodel/EditRecurringExpenseViewModel.kt
Show resolved
Hide resolved
Allow the option to define default days in advance to receive a reminder while allowing to define a custom set of days for each single expense to also receive multiple reminders for them.
0ec712f to
87bf4e3
Compare
87bf4e3 to
b9e1019
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #717