Skip to content

Conversation

@verkaik
Copy link
Contributor

@verkaik verkaik commented Apr 16, 2025

Fixes #1498

Description

PR for @verkaik to push his bug fix and additional unittest(s) to support this.

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

@verkaik verkaik requested a review from JoerivanEngelen April 16, 2025 13:30
@verkaik verkaik self-assigned this Apr 16, 2025
@sonarqubecloud
Copy link

Copy link
Contributor

@JoerivanEngelen JoerivanEngelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

I took the liberty of fixing the mypy issue and adding some unittests, for both structured as well as unstructured models.

@JoerivanEngelen JoerivanEngelen merged commit e1df40e into master Apr 17, 2025
7 checks passed
@JoerivanEngelen JoerivanEngelen deleted the issue_#1498_package_broken_copy_method branch April 17, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mf6 Package: copy method is broken

3 participants