Add PromiseHook bindings#453
Conversation
|
@bnoordhuis The preliminary check results are commented in the following places: |
nabetti1720
left a comment
There was a problem hiding this comment.
@bnoordhuis Thank you! I just made one comment.
@DelSkayn We are currently building an experimental runtime using this awesome Rust Binding and are looking forward to using these V8 inspired promise hooks in the runtime. Can you please review this PR when you have time?
|
@DelSkayn PTAL, thanks in advance :) |
DelSkayn
left a comment
There was a problem hiding this comment.
Looks good, only the bindings for other platforms need to be updated.
Let me know if you can access the artifacts from the CI action otherwise I will do the binding update in a separate PR which you can merge in.
@DelSkayn Thank you! By the way, does the CI deliverable include aarch64/darwin? When the owner of this PR asked me to test it, the bindings for my environment were not included, so I forked the branch from which the PR originated and added the bindings for aarch64/darwin to it for testing. It's working fine so far, so I think you can go ahead and do it. The status of the verification can be found here. |
|
@DelSkayn Sorry for the confusing explanation. In my environment, I can't verify from CI artifacts, so it would be helpful if you could merge it once and then create another PR to update the binding. :) |
|
@DelSkayn I've updated the bindings except for x86_64-pc-windows-msvc because those two buildbots error while generating the bindings (i.e., before uploading them) for reasons that aren't clear to me. |
|
@DelSkayn I would be very grateful if you could check it out when you have time. :) |
Upcoming new API, see quickjs-ng/quickjs#1030 and quickjs-ng/quickjs#1033.