Skip to content

Conversation

@cyfung1031
Copy link
Contributor

@cyfung1031 cyfung1031 commented Oct 22, 2025

There is a typo in the current description for chrome.declarativeNetRequest.RuleCondition.tabIds.
This PR is to fix the typo.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 22, 2025

@cyfung1031 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 73949,
  "author": "cyfung1031",
  "headCommitOid": "f77a9dc7debfa4eb1051fbeac99dab6459b083c1",
  "mergeBaseOid": "5113b30d6faf04abd33dc2adf2de4d96d3ec4e94",
  "lastPushDate": "2025-10-22T09:16:04.000Z",
  "lastActivityDate": "2025-11-11T21:37:59.000Z",
  "mergeOfferDate": "2025-11-11T20:20:01.000Z",
  "mergeRequestDate": "2025-11-11T21:37:59.000Z",
  "mergeRequestUser": "erwanjugand",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "chrome",
      "kind": "edit",
      "files": [
        {
          "path": "types/chrome/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "matthewkimber",
        "otiai10",
        "sreimer15",
        "MatCarlson",
        "ekinsol",
        "echoabstract",
        "spasma",
        "bdbai",
        "JasonXian",
        "usertim",
        "idan315",
        "nicolas377",
        "idosal",
        "fregante",
        "erwanjugand"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2025-11-11T20:19:20.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "erwanjugand",
      "date": "2025-10-22T09:25:33.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 3431285556,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

Hey @cyfung1031,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Contributor

🔔 @matthewkimber @otiai10 @sreimer15 @matcarlson @ekinsol @EchoAbstract @spasma @bdbai @JasonXian @userTim @idan315 @nicolas377 @idosal @fregante @erwanjugand — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Oct 22, 2025
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Oct 22, 2025
@cyfung1031
Copy link
Contributor Author

Hey @cyfung1031,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Typo Correction for Description does not require any modification of the existing tests.

@typescript-bot
Copy link
Contributor

⏳ Hi @cyfung1031,

It's been a few days since this PR was approved by erwanjugand and we're waiting for a DT maintainer to give a review.

If you would like to short-circuit this wait, you can edit some of the test files in the package that verify how the .d.ts files work. This would allow the PR to be merged by you or the DT module owners after a re-review.

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Nov 2, 2025
@typescript-bot
Copy link
Contributor

Re-ping @matthewkimber, @otiai10, @sreimer15, @matcarlson, @ekinsol, @EchoAbstract, @spasma, @bdbai, @JasonXian, @userTim, @idan315, @nicolas377, @idosal, @fregante:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Maintainer Action in Pull Request Status Board Nov 10, 2025
@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @cyfung1031.

(Ping @matthewkimber, @otiai10, @sreimer15, @matcarlson, @ekinsol, @EchoAbstract, @spasma, @bdbai, @JasonXian, @userTim, @idan315, @nicolas377, @idosal, @fregante.)

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Nov 11, 2025
@typescript-bot
Copy link
Contributor

@cyfung1031: Everything looks good here. I am ready to merge this PR (at f77a9dc) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@matthewkimber, @otiai10, @sreimer15, @matcarlson, @ekinsol, @EchoAbstract, @spasma, @bdbai, @JasonXian, @userTim, @idan315, @nicolas377, @idosal, @fregante, @erwanjugand: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in Pull Request Status Board Nov 11, 2025
@erwanjugand
Copy link
Contributor

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Nov 11, 2025
@typescript-bot typescript-bot merged commit 51b82cb into DefinitelyTyped:master Nov 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Critical package Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong Description for chrome.declarativeNetRequest.RuleCondition.tabIds

4 participants