Skip to content

[leaflet] Make CircleMarkerOptions.radius optional#73812

Merged
typescript-bot merged 9 commits intoDefinitelyTyped:masterfrom
lt25106:master
Oct 11, 2025
Merged

[leaflet] Make CircleMarkerOptions.radius optional#73812
typescript-bot merged 9 commits intoDefinitelyTyped:masterfrom
lt25106:master

Conversation

@lt25106
Copy link
Copy Markdown
Contributor

@lt25106 lt25106 commented Oct 3, 2025

Please fill in this template.

Select one of these and delete the others:
If changing an existing definition:

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Oct 3, 2025

@lt25106 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 73812,
  "author": "lt25106",
  "headCommitOid": "b0fe8d0deb2ab8bf23ea87642319bb46617f76c2",
  "mergeBaseOid": "c0c53290db2018b7cbb54205a517e16a34c334c9",
  "lastPushDate": "2025-10-03T11:06:32.000Z",
  "lastActivityDate": "2025-10-11T01:10:39.000Z",
  "mergeOfferDate": "2025-10-11T01:06:16.000Z",
  "mergeRequestDate": "2025-10-11T01:10:39.000Z",
  "mergeRequestUser": "lt25106",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "leaflet",
      "kind": "edit",
      "files": [
        {
          "path": "types/leaflet/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/leaflet/leaflet-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "alejo90",
        "atd-schubert",
        "mcauer",
        "ronikar",
        "life777",
        "henrythasler",
        "captain-igloo",
        "someonewithpc"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2025-10-11T01:03:22.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "henrythasler",
      "date": "2025-10-04T07:17:17.000Z",
      "abbrOid": "71e217f"
    }
  ],
  "mainBotCommentID": 3365282667,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @alejo90 @atd-schubert @mcauer @ronikar @life777 @henrythasler @captain-igloo @someonewithpc — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Oct 3, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in Pull Request Status Board Oct 3, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@lt25106 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Oct 3, 2025
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board Oct 3, 2025
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Oct 3, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in Pull Request Status Board Oct 3, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@lt25106 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Oct 3, 2025
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board Oct 3, 2025
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Oct 3, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@lt25106 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in Pull Request Status Board Oct 3, 2025
@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Oct 3, 2025
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board Oct 3, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Oct 3, 2025
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in Pull Request Status Board Oct 3, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Oct 3, 2025
@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Oct 3, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@lt25106 One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@typescript-bot typescript-bot removed the Revision needed This PR needs code changes before it can be merged. label Oct 4, 2025
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board Oct 4, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Oct 4, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@henrythasler Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in Pull Request Status Board Oct 4, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Oct 4, 2025
@lt25106 lt25106 requested a review from henrythasler October 4, 2025 05:59
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Oct 4, 2025
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in Pull Request Status Board Oct 7, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Oct 7, 2025
@lt25106
Copy link
Copy Markdown
Contributor Author

lt25106 commented Oct 10, 2025

By the way how long do these reviews usually take?

@typescript-bot typescript-bot removed the Owner Approved A listed owner of this package signed off on the pull request. label Oct 11, 2025
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in Pull Request Status Board Oct 11, 2025
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 11, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@lt25106: Everything looks good here. I am ready to merge this PR (at b0fe8d0) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@alejo90, @atd-schubert, @mcauer, @ronikar, @life777, @henrythasler, @captain-igloo, @someonewithpc: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board Oct 11, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@henrythasler Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@lt25106
Copy link
Copy Markdown
Contributor Author

lt25106 commented Oct 11, 2025

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Oct 11, 2025
@typescript-bot typescript-bot merged commit d0c2eaa into DefinitelyTyped:master Oct 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Critical package Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants