Revert "[node] Add generics to static members of EventEmitter"#71054
Merged
Revert "[node] Add generics to static members of EventEmitter"#71054
EventEmitter"#71054Conversation
…ventEmit…" This reverts commit 1d35480.
Contributor
|
@gabritto Thank you for submitting this PR! This is a live comment that I will keep updated. 14 packages in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 71054,
"author": "gabritto",
"headCommitOid": "947e25d41e45adbc41c71b812d73e20e0248bb53",
"mergeBaseOid": "111ed01fd858da3c0d4219f06db9d80bb6312127",
"lastPushDate": "2024-10-31T17:38:10.000Z",
"lastActivityDate": "2024-10-31T17:48:04.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "imap",
"kind": "edit",
"files": [
{
"path": "types/imap/index.d.ts",
"kind": "definition"
}
],
"owners": [
"psnider"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "jake",
"kind": "edit",
"files": [
{
"path": "types/jake/index.d.ts",
"kind": "definition"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "newman",
"kind": "edit",
"files": [
{
"path": "types/newman/newman-tests.ts",
"kind": "test"
}
],
"owners": [
"LogvinovLeon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "node-red",
"kind": "edit",
"files": [
{
"path": "types/node-red/node-red-tests.ts",
"kind": "test"
}
],
"owners": [
"andersea",
"tbowmo",
"bernardobelchior",
"alexk111",
"Shaquu"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/events.ts",
"kind": "test"
},
{
"path": "types/node/test/events_generic.ts",
"kind": "test"
},
{
"path": "types/node/v16/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/test/events_generic.ts",
"kind": "test"
},
{
"path": "types/node/v18/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/test/events.ts",
"kind": "test"
},
{
"path": "types/node/v18/test/events_generic.ts",
"kind": "test"
},
{
"path": "types/node/v20/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/test/events.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/events_generic.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "opossum",
"kind": "edit",
"files": [
{
"path": "types/opossum/opossum-tests.ts",
"kind": "test"
}
],
"owners": [
"quinnlangille",
"merufm",
"lance",
"mastermatt",
"tjenkinson"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "rdf-store-fs",
"kind": "edit",
"files": [
{
"path": "types/rdf-store-fs/rdf-store-fs-tests.ts",
"kind": "test"
}
],
"owners": [
"tpluscode"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "readable-stream",
"kind": "edit",
"files": [
{
"path": "types/readable-stream/index.d.ts",
"kind": "definition"
}
],
"owners": [
"TeamworkGuy2",
"markdreyer",
"mcollina"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "sane",
"kind": "edit",
"files": [
{
"path": "types/sane/index.d.ts",
"kind": "definition"
}
],
"owners": [
"BendingBender"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "sse",
"kind": "edit",
"files": [
{
"path": "types/sse/sse-tests.ts",
"kind": "test"
}
],
"owners": [
"yutak23"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "steam",
"kind": "edit",
"files": [
{
"path": "types/steam/index.d.ts",
"kind": "definition"
}
],
"owners": [
"kant2002"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "twitter",
"kind": "edit",
"files": [
{
"path": "types/twitter/twitter-tests.ts",
"kind": "test"
}
],
"owners": [
"BendingBender"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "umzug",
"kind": "edit",
"files": [
{
"path": "types/umzug/index.d.ts",
"kind": "definition"
}
],
"owners": [
"drinchev",
"mlamp",
"trodi",
"emmanuelgautier"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "xml-flow",
"kind": "edit",
"files": [
{
"path": "types/xml-flow/xml-flow-tests.ts",
"kind": "test"
}
],
"owners": [
"Warerebel"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2024-10-31T17:48:04.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2450459092,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/947e25d41e45adbc41c71b812d73e20e0248bb53/checks?check_suite_id=30348210207"
} |
Contributor
People who would have been pingedpsnider LogvinovLeon andersea tbowmo bernardobelchior alexk111 Shaquu Microsoft jkomyno alvis r3nya btoueg smac89 touffy DeividasBakanas eyqs Hannes-Magnusson-CK hoo29 kjin ajafff islishude mwiktorczyk mohsen1 galkin parambirs eps1lon ThomasdenH WilcoBakker wwwy3y3 samuela kuehlein bhongy chyzwar trivikr yoursunny qwelias ExE-Boss peterblazejewicz addaleax victorperin ZYSzys NodeJS LinusU wafuwafu13 mcollina Semigradsky quinnlangille merufm lance mastermatt tjenkinson tpluscode TeamworkGuy2 markdreyer BendingBender yutak23 kant2002 drinchev mlamp trodi emmanuelgautier Warerebel |
Contributor
|
@gabritto The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
Member
|
Fixed that one CI failure in #71058 |
This was referenced Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #69997.
See #71050.