Skip to content

Remove req-real-ip#70948

Merged
jakebailey merged 1 commit intoDefinitelyTyped:masterfrom
jakebailey:remove-req-real-ip
Oct 18, 2024
Merged

Remove req-real-ip#70948
jakebailey merged 1 commit intoDefinitelyTyped:masterfrom
jakebailey:remove-req-real-ip

Conversation

@jakebailey
Copy link
Copy Markdown
Member

This package was unpublished from npm on October 13th, not long after it was added to DT. This is blocking CI.

Just delete the package. DT is not the place for non-existent or private packages.

@jakebailey
Copy link
Copy Markdown
Member Author

jakebailey commented Oct 18, 2024

ref #70868 (comment) #70756

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Oct 18, 2024

@jakebailey Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 70948,
  "author": "jakebailey",
  "headCommitOid": "d285e928c1ffca40d02a3e4ec5e6093b2829a0f3",
  "mergeBaseOid": "034ada8c1c566190d07422a74d059ed873c1a417",
  "lastPushDate": "2024-10-18T17:10:54.000Z",
  "lastActivityDate": "2024-10-18T17:11:17.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "req-real-ip",
      "kind": "delete",
      "files": [
        {
          "path": "types/req-real-ip/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/req-real-ip/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/req-real-ip/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/req-real-ip/req-real-ip-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/req-real-ip/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "lacherogwu"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2422905655,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @lacherogwu — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@jakebailey
Copy link
Copy Markdown
Member Author

I'm going to merge this to unblock CI. This can be reverted if the package comes back.

@jakebailey jakebailey merged commit 022f7f6 into DefinitelyTyped:master Oct 18, 2024
@jakebailey jakebailey deleted the remove-req-real-ip branch October 18, 2024 17:37
@jakebailey jakebailey mentioned this pull request Oct 18, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants