Skip to content

Fix various ecosystem breaks#70297

Merged
jakebailey merged 1 commit intoDefinitelyTyped:masterfrom
jakebailey:fix-types-wow
Aug 15, 2024
Merged

Fix various ecosystem breaks#70297
jakebailey merged 1 commit intoDefinitelyTyped:masterfrom
jakebailey:fix-types-wow

Conversation

@jakebailey
Copy link
Member

  • @npm/types broke and changed PackageJson to PackageJSON.
  • fontagon was not updated to request an older version of svgicons2svgfont.
  • unist is now a placeholder package on npm.

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 15, 2024

@jakebailey Thank you for submitting this PR!

This is a live comment that I will keep updated.

4 packages in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes that affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 70297,
  "author": "jakebailey",
  "headCommitOid": "e97e3960378f023dbbe6a2a768a29ff7a0089eac",
  "mergeBaseOid": "bf7bc8af94ce2c429016256fd437d0667d7bed70",
  "lastPushDate": "2024-08-15T01:48:01.000Z",
  "lastActivityDate": "2024-08-15T01:48:01.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "fontagon",
      "kind": "edit",
      "files": [
        {
          "path": "types/fontagon/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "libnpmpublish",
      "kind": "edit",
      "files": [
        {
          "path": "types/libnpmpublish/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "nicolas377",
        "Guy-Adler"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "npmcli__arborist",
      "kind": "edit",
      "files": [
        {
          "path": "types/npmcli__arborist/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "forivall",
        "russellhaering"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "unist",
      "kind": "edit",
      "files": [
        {
          "path": "types/unist/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/unist/v2/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "bizen241",
        "lujun2",
        "hrajchert",
        "wooorm",
        "rokt33r",
        "GuiltyDolphin",
        "JounQin",
        "remcohaszing"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2290320626,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @peterblazejewicz @nicolas377 @Guy-Adler @forivall @russellhaering @bizen241 @lujun2 @hrajchert @wooorm @Rokt33r @GuiltyDolphin @JounQin @remcohaszing — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@jakebailey jakebailey merged commit b3ce4d3 into DefinitelyTyped:master Aug 15, 2024
@jakebailey jakebailey deleted the fix-types-wow branch August 15, 2024 01:52
@jakebailey
Copy link
Member Author

For future reference, we may just want to change @npm/types to v2+ and then import PackageJSON, but this was the safer move for now to unblock the rest of DT.

Copy link
Contributor

@forivall forivall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @npmcli/arborist

@remcohaszing
Copy link
Contributor

I received ownership of the unist package and deprecated it. We intend to keep using @types/unist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants