Skip to content

[diff] Add ESM entrypoint #69537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 2 commits into from
May 6, 2024
Merged

[diff] Add ESM entrypoint #69537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8b1d27
[diff] Add ESM entrypoint
andrewbranch May 6, 2024
4c9b00b
Format
andrewbranch May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion attw.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,6 @@
"dhtmlxgantt",
"dhtmlxscheduler",
"dialogify-browser",
"diff",
"digital-goods-browser",
"doccookies",
"dock-spawn",
Expand Down
4 changes: 4 additions & 0 deletions types/diff/diff-tests.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
// @ts-expect-error
import ThereIsNoDefaultExport, { Diff } from "diff";

new Diff();
1 change: 1 addition & 0 deletions types/diff/index.d.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from "./index.js";
Copy link
Member Author

@andrewbranch andrewbranch May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index.mjs is actually a duplicated bundle, but re-exporting instead of duplicating types is the better tradeoff for now

9 changes: 8 additions & 1 deletion types/diff/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,12 @@
"name": "Piotr Błażejewicz",
"githubUsername": "peterblazejewicz"
}
]
],
"exports": {
".": {
"import": "./index.d.mts",
"require": "./index.d.ts"
},
"./package.json": "./package.json"
Copy link
Member Author

@andrewbranch andrewbranch May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff also exposes "./*", but I didn’t handle that for now since the types have never exposed individual files.

}
}
3 changes: 2 additions & 1 deletion types/diff/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
},
"files": [
"index.d.ts",
"diff-tests.ts"
"diff-tests.ts",
"diff-tests.mts"
]
}