[@types/hotwired__turbo] add types for StreamActions and events#69392
[@types/hotwired__turbo] add types for StreamActions and events#69392typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
Conversation
|
@jdelStrother Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69392,
"author": "jdelStrother",
"headCommitOid": "fff9a8ed0e4773e83d235c39f2d6e7e9e733eec6",
"mergeBaseOid": "7c28187a1abdad59a6e044e19ce49a0f3905659a",
"lastPushDate": "2024-04-18T15:00:27.000Z",
"lastActivityDate": "2024-04-19T08:30:01.000Z",
"mergeOfferDate": "2024-04-19T08:24:56.000Z",
"mergeRequestDate": "2024-04-19T08:30:01.000Z",
"mergeRequestUser": "G-Rath",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "hotwired__turbo",
"kind": "edit",
"files": [
{
"path": "types/hotwired__turbo/hotwired__turbo-tests.ts",
"kind": "test"
},
{
"path": "types/hotwired__turbo/index.d.ts",
"kind": "definition"
}
],
"owners": [
"G-Rath",
"lukeify"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "Anonymous4078",
"date": "2024-04-19T08:24:15.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2064130447,
"ciResult": "pass"
} |
|
🔔 @G-Rath @lukeify — please review this PR in the next few days. Be sure to explicitly select |
|
@jdelStrother The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
880c411 to
2c69794
Compare
2c69794 to
fff9a8e
Compare
|
@jdelStrother: Everything looks good here. I am ready to merge this PR (at fff9a8e) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
pnpm test <package to test>.Turbo manual
The new types are largely cribbed from @marcoroth's PR adding better types for their events, and older versions of Turbo from before they deleted all their Typescript