Skip to content

[@types/hotwired__turbo] add types for StreamActions and events#69392

Merged
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
jdelStrother:hotwired-turbo
Apr 19, 2024
Merged

[@types/hotwired__turbo] add types for StreamActions and events#69392
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
jdelStrother:hotwired-turbo

Conversation

@jdelStrother
Copy link
Copy Markdown
Contributor

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change.
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run pnpm test <package to test>.
  • Provide a URL to documentation or source code which provides context for the suggested changes:

Turbo manual

The new types are largely cribbed from @marcoroth's PR adding better types for their events, and older versions of Turbo from before they deleted all their Typescript

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 18, 2024

@jdelStrother Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69392,
  "author": "jdelStrother",
  "headCommitOid": "fff9a8ed0e4773e83d235c39f2d6e7e9e733eec6",
  "mergeBaseOid": "7c28187a1abdad59a6e044e19ce49a0f3905659a",
  "lastPushDate": "2024-04-18T15:00:27.000Z",
  "lastActivityDate": "2024-04-19T08:30:01.000Z",
  "mergeOfferDate": "2024-04-19T08:24:56.000Z",
  "mergeRequestDate": "2024-04-19T08:30:01.000Z",
  "mergeRequestUser": "G-Rath",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "hotwired__turbo",
      "kind": "edit",
      "files": [
        {
          "path": "types/hotwired__turbo/hotwired__turbo-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/hotwired__turbo/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "G-Rath",
        "lukeify"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Anonymous4078",
      "date": "2024-04-19T08:24:15.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2064130447,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @G-Rath @lukeify — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Copy Markdown
Contributor

@jdelStrother The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Apr 18, 2024
@jdelStrother jdelStrother changed the title [hotwired__turbo] add types for StreamActions and events [@types/hotwired__turbo] add types for StreamActions and events Apr 18, 2024
@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels Apr 19, 2024
@typescript-bot
Copy link
Copy Markdown
Contributor

@jdelStrother: Everything looks good here. I am ready to merge this PR (at fff9a8e) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@G-Rath, @lukeify: you can do this too.)

@G-Rath
Copy link
Copy Markdown
Contributor

G-Rath commented Apr 19, 2024

Ready to merge

@typescript-bot typescript-bot merged commit dcd413c into DefinitelyTyped:master Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants