Skip to content

Base MDX type tests on real world examples #68955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 9 commits into from
Mar 22, 2024
Merged

Base MDX type tests on real world examples #68955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e5c0417
Base MDX type tests on real worls examples
remcohaszing Mar 11, 2024
936413d
Refactor MDX setup
remcohaszing Mar 11, 2024
c7666ca
Fix some copy-paste errors
remcohaszing Mar 11, 2024
d0d8144
Restore framework-less MDX tests
remcohaszing Mar 11, 2024
b69a78b
Update MDX tsconfigs
remcohaszing Mar 11, 2024
8c86bd0
Update types/mdx/package.json
remcohaszing Mar 11, 2024
178f8b9
Remove frameworkless tests
remcohaszing Mar 11, 2024
de6df32
Remove redundant types from mdx
remcohaszing Mar 11, 2024
d51924e
Fix the use of JSX.Element in mdx index.d.ts
remcohaszing Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions types/mdx/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
*/
declare module "*.mdx" {
// eslint-disable-next-line @definitelytyped/no-self-import
import { MDXProps } from "mdx/types";
import { Element, MDXProps } from "mdx/types";

/**
* An function component which renders the MDX content using JSX.
Expand All @@ -61,7 +61,7 @@ declare module "*.mdx" {
* @returns A JSX element. The meaning of this may depend on the project configuration. I.e. it
* could be a React, Preact, or Vuex element.
*/
export default function MDXContent(props: MDXProps): JSX.Element;
export default function MDXContent(props: MDXProps): Element;
}

// Support markdown extensions from
Expand Down
5 changes: 4 additions & 1 deletion types/mdx/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,11 @@
"projects": [
"https://github.com/mdx-js/mdx"
],
"tsconfigs": ["tsconfig.preact.json", "tsconfig.react.json"],
"devDependencies": {
"@types/mdx": "workspace:."
"@types/mdx": "workspace:.",
"@types/react": "*",
"preact": "*"
},
"owners": [
{
Expand Down
Loading