[@types/node] Fix types for TS-next #68291
Conversation
|
@codershiba Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 68291,
"author": "codershiba",
"headCommitOid": "5575f6abbbb2ab014c46c99fc185fd95f2c4fa47",
"mergeBaseOid": "7428cc9dec89e7e26692334698f85f721b12ab87",
"lastPushDate": "2024-01-23T05:23:54.000Z",
"lastActivityDate": "2024-01-23T09:09:19.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/ts4.8/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/ts4.8/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/ts4.8/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/ts4.8/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/ts4.8/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/ts4.8/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/stream.d.ts",
"kind": "definition"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"n-e",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 1905314748,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/5575f6abbbb2ab014c46c99fc185fd95f2c4fa47/checks?check_suite_id=20030027498"
} |
|
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
|
@codershiba The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
| } | ||
| declare module "node:events" { | ||
| import events = require("events"); | ||
| import type events = require("events"); |
There was a problem hiding this comment.
Why? It is not a type only
|
for transparency: x-ref #68285 |
|
@codershiba it looks like this PR can be closed. It was bug in TS and it was fixed. |
|
Yeah, fixed in microsoft/TypeScript#57148. |
Please fill in this template.
pnpm test <package to test>.If changing an existing definition:
package.json.