Skip to content

[react-timeago] Replace usage of React's global JSX namespace with scoped JSX #67716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 3 commits into from
Dec 26, 2023
Merged

[react-timeago] Replace usage of React's global JSX namespace with scoped JSX #67716

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f7386d
[react-timeago] Replace usage of React's global JSX namespace with sc…
eps1lon Dec 3, 2023
b7882e4
Merge branch 'master' into feat/deprecated-jsx/react-timeago
eps1lon Dec 5, 2023
d390757
Merge branch 'master' into feat/deprecated-jsx/react-timeago
eps1lon Dec 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions types/react-timeago/react-timeago-tests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as React from "react";
import ReactTimeago, { Suffix, Unit } from "react-timeago";

const ReactTimeagoRequiredOptions: JSX.Element = <ReactTimeago date={new Date()} />;
const ReactTimeagoRequiredOptions: React.JSX.Element = <ReactTimeago date={new Date()} />;

const customFormatter = (
value: number,
Expand All @@ -14,7 +14,7 @@ const customFormatter = (
: "a really long time ago";
};

const ReactTimeagoAllOptions: JSX.Element = (
const ReactTimeagoAllOptions: React.JSX.Element = (
<ReactTimeago
date={new Date()}
live
Expand All @@ -26,12 +26,12 @@ const ReactTimeagoAllOptions: JSX.Element = (
/>
);

const ReactTimeagoDefaultComponentProps: JSX.Element = (
const ReactTimeagoDefaultComponentProps: React.JSX.Element = (
// Note that the default component is <time/>, which has a style prop.
<ReactTimeago
(<ReactTimeago
date={new Date()}
style={{ marginTop: 42 }}
/>
/>)
);

// inspired by react-native
Expand All @@ -42,7 +42,7 @@ class Text extends React.Component<{
allowFontScaling?: boolean | undefined;
}> {}

const ReactTimeagoCustomComponent: JSX.Element = (
const ReactTimeagoCustomComponent: React.JSX.Element = (
<ReactTimeago<typeof Text>
date={new Date()}
component={Text}
Expand Down