-
Notifications
You must be signed in to change notification settings - Fork 30.5k
[react-mixin] Replace usage of React's global JSX namespace with scoped JSX #67670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react-mixin] Replace usage of React's global JSX namespace with scoped JSX #67670
Conversation
…ed JSX Was deprecated in DefinitelyTyped#64464
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 67670,
"author": "eps1lon",
"headCommitOid": "4e5a04fcfbc132eddff807545c3604a185e0987f",
"mergeBaseOid": "d92681b0bdcc4b673215b88add00480fd996e18d",
"lastPushDate": "2023-12-03T16:54:48.000Z",
"lastActivityDate": "2023-12-15T18:17:01.000Z",
"mergeOfferDate": "2023-12-14T22:13:48.000Z",
"mergeRequestDate": "2023-12-15T18:17:01.000Z",
"mergeRequestUser": "eps1lon",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "react-mixin",
"kind": "edit",
"files": [
{
"path": "types/react-mixin/react-mixin-tests.tsx",
"kind": "test"
}
],
"owners": [
"tkqubo"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "tkqubo",
"date": "2023-12-14T22:13:03.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1837537749,
"ciResult": "pass"
} |
|
🔔 @tkqubo — please review this PR in the next few days. Be sure to explicitly select |
|
Re-ping @tkqubo: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
tkqubo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
Ready to merge |
Was deprecated in #64464. Cherry-picked from #67588.