Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Dec 3, 2023

Was deprecated in #64464. Cherry-picked from #67588.

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 3, 2023

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 67670,
  "author": "eps1lon",
  "headCommitOid": "4e5a04fcfbc132eddff807545c3604a185e0987f",
  "mergeBaseOid": "d92681b0bdcc4b673215b88add00480fd996e18d",
  "lastPushDate": "2023-12-03T16:54:48.000Z",
  "lastActivityDate": "2023-12-15T18:17:01.000Z",
  "mergeOfferDate": "2023-12-14T22:13:48.000Z",
  "mergeRequestDate": "2023-12-15T18:17:01.000Z",
  "mergeRequestUser": "eps1lon",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "react-mixin",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-mixin/react-mixin-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "tkqubo"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "tkqubo",
      "date": "2023-12-14T22:13:03.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1837537749,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @tkqubo — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Dec 14, 2023
@typescript-bot
Copy link
Contributor

Re-ping @tkqubo:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

Copy link
Contributor

@tkqubo tkqubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Dec 14, 2023
@typescript-bot
Copy link
Contributor

@eps1lon: Everything looks good here. I am ready to merge this PR (at 4e5a04f) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@tkqubo: you can do this too.)

@eps1lon
Copy link
Collaborator Author

eps1lon commented Dec 15, 2023

Ready to merge

@typescript-bot typescript-bot merged commit d02e0c2 into DefinitelyTyped:master Dec 15, 2023
@eps1lon eps1lon deleted the feat/deprecated-jsx/react-mixin branch December 15, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants