[react-hamburger-menu] Replace usage of React's global JSX namespace with scoped JSX #67656
Conversation
…with scoped JSX Was deprecated in DefinitelyTyped#64464
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 67656,
"author": "eps1lon",
"headCommitOid": "6c40a5ef61da9216f8b99245c6ebce57a32fba21",
"mergeBaseOid": "d92681b0bdcc4b673215b88add00480fd996e18d",
"lastPushDate": "2023-12-03T16:52:52.000Z",
"lastActivityDate": "2023-12-15T18:17:30.000Z",
"mergeOfferDate": "2023-12-15T10:30:43.000Z",
"mergeRequestDate": "2023-12-15T18:17:30.000Z",
"mergeRequestUser": "eps1lon",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "react-hamburger-menu",
"kind": "edit",
"files": [
{
"path": "types/react-hamburger-menu/react-hamburger-menu-tests.tsx",
"kind": "test"
}
],
"owners": [
"grzesie2k"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "Grzesie2k",
"date": "2023-12-15T10:29:57.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1837537277,
"ciResult": "pass"
} |
|
🔔 @Grzesie2k — please review this PR in the next few days. Be sure to explicitly select |
|
Re-ping @Grzesie2k: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
@eps1lon: Everything looks good here. I am ready to merge this PR (at 6c40a5e) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@Grzesie2k: you can do this too.) |
|
Ready to merge |
Was deprecated in #64464. Cherry-picked from #67588.