Skip to content

[react-flex] Replace usage of React's global JSX namespace with scoped JSX #67649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 2 commits into from
Dec 26, 2023
Merged

[react-flex] Replace usage of React's global JSX namespace with scoped JSX #67649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fd67c8
[react-flex] Replace usage of React's global JSX namespace with scope…
eps1lon Dec 3, 2023
42a20f2
Merge branch 'master' into feat/deprecated-jsx/react-flex
eps1lon Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions types/react-flex/react-flex-tests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,30 @@
import * as React from "react";
import { Flex, Item } from "react-flex";

const ex1: JSX.Element = (
const ex1: React.JSX.Element = (
<Flex row alignItems="center">
<div>a first div</div>
<Item flex={1}>flexes to 1</Item>
</Flex>
);

const ex2: JSX.Element = (
const ex2: React.JSX.Element = (
<Flex alignItems="start">
<Item flex={2}>
content here
</Item>
</Flex>
);

const ex3: JSX.Element = (
const ex3: React.JSX.Element = (
<Flex alignItems="flex-start">
<Item flex={"2"}>
content here
</Item>
</Flex>
);

const ex4: JSX.Element = (
const ex4: React.JSX.Element = (
<Flex column wrap={false}>
<Flex flex={false}>
Flex also supports the `flex` prop
Expand Down