Skip to content

Update no-unnecessary-generics locations#67331

Merged
sandersn merged 1 commit intoDefinitelyTyped:masterfrom
sandersn:update-no-unnecessary-generics-locations
Nov 6, 2023
Merged

Update no-unnecessary-generics locations#67331
sandersn merged 1 commit intoDefinitelyTyped:masterfrom
sandersn:update-no-unnecessary-generics-locations

Conversation

@sandersn
Copy link
Contributor

@sandersn sandersn commented Nov 6, 2023

The location of error reporting changed recently: microsoft/DefinitelyTyped-tools#794

The location of error reporting changed recently
@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 6, 2023

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

48 packages in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have failed
  • ✅ A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 67331,
  "author": "sandersn",
  "headCommitOid": "1225430dfa5cbd8207ecb9098eec8c542d62c7aa",
  "mergeBaseOid": "f60a64b1e0e8f7f8ef4db547e283226d17ad9e86",
  "lastPushDate": "2023-11-06T18:05:53.000Z",
  "lastActivityDate": "2023-11-06T18:08:29.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "alpinejs",
      "kind": "edit",
      "files": [
        {
          "path": "types/alpinejs/alpinejs-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/alpinejs/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "wtho",
        "ekwoka"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "amap-js-api",
      "kind": "edit",
      "files": [
        {
          "path": "types/amap-js-api/event.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "breeze9527"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "barnard59-base",
      "kind": "edit",
      "files": [
        {
          "path": "types/barnard59-base/map.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tpluscode",
        "BenjaminHofstetter"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "bent",
      "kind": "edit",
      "files": [
        {
          "path": "types/bent/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Ovyerus"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "conventional-changelog-writer",
      "kind": "edit",
      "files": [
        {
          "path": "types/conventional-changelog-writer/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "JasonHK"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "d3-drag",
      "kind": "edit",
      "files": [
        {
          "path": "types/d3-drag/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tomwanzek",
        "gustavderdrache",
        "borisyankov",
        "Methuselah96"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "d3-dsv",
      "kind": "edit",
      "files": [
        {
          "path": "types/d3-dsv/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/d3-dsv/v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/d3-dsv/v2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tomwanzek",
        "gustavderdrache",
        "borisyankov",
        "denisname",
        "Methuselah96"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "d3-fetch",
      "kind": "edit",
      "files": [
        {
          "path": "types/d3-fetch/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ledragon",
        "denisname",
        "Methuselah96"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "d3-force",
      "kind": "edit",
      "files": [
        {
          "path": "types/d3-force/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tomwanzek",
        "gustavderdrache",
        "borisyankov",
        "denisname",
        "Methuselah96"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "d3-geo",
      "kind": "edit",
      "files": [
        {
          "path": "types/d3-geo/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ledragon",
        "tomwanzek",
        "gustavderdrache",
        "borisyankov",
        "Methuselah96"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "d3-scale",
      "kind": "edit",
      "files": [
        {
          "path": "types/d3-scale/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tomwanzek",
        "gustavderdrache",
        "borisyankov",
        "denisname",
        "rulonder",
        "Methuselah96"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "d3-selection",
      "kind": "edit",
      "files": [
        {
          "path": "types/d3-selection/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tomwanzek",
        "gustavderdrache",
        "borisyankov",
        "denisname",
        "Methuselah96",
        "ambar-arkin"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "d3-transition",
      "kind": "edit",
      "files": [
        {
          "path": "types/d3-transition/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tomwanzek",
        "gustavderdrache",
        "borisyankov",
        "robertmoura",
        "Methuselah96"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "d3-zoom",
      "kind": "edit",
      "files": [
        {
          "path": "types/d3-zoom/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tomwanzek",
        "gustavderdrache",
        "borisyankov",
        "denisname",
        "Methuselah96"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "dbus",
      "kind": "edit",
      "files": [
        {
          "path": "types/dbus/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "lal12"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "enzyme-react-intl",
      "kind": "edit",
      "files": [
        {
          "path": "types/enzyme-react-intl/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "mateusz-meller"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "express-serve-static-core",
      "kind": "edit",
      "files": [
        {
          "path": "types/express-serve-static-core/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "borisyankov",
        "micksatana",
        "samijaber",
        "JoseLion",
        "dwrss",
        "andoshin11"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "hifo",
      "kind": "edit",
      "files": [
        {
          "path": "types/hifo/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "jquery",
      "kind": "edit",
      "files": [
        {
          "path": "types/jquery/JQueryStatic.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "leonard-thieu",
        "borisyankov",
        "choffmeister",
        "Steve-Fenton",
        "Diullei",
        "tasoili",
        "seanski",
        "Guuz",
        "ksummerlin",
        "basarat",
        "nwolverson",
        "derekcicerone",
        "AndrewGaspar",
        "seikichi",
        "benjaminjackman",
        "JoshStrobl",
        "johnnyreilly",
        "DickvdBrink",
        "King2500",
        "terrymun",
        "martin-badin",
        "princefishthrower"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "meteor-dburles-collection-helpers",
      "kind": "edit",
      "files": [
        {
          "path": "types/meteor-dburles-collection-helpers/mongo.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "artemiswkearney"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "morgan",
      "kind": "edit",
      "files": [
        {
          "path": "types/morgan/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "staticfunction",
        "pscanf",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "neo-async",
      "kind": "edit",
      "files": [
        {
          "path": "types/neo-async/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "corentinverpillat"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "node-red__editor-client",
      "kind": "edit",
      "files": [
        {
          "path": "types/node-red__editor-client/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "alexk111",
        "Shaquu"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "oojs-ui",
      "kind": "edit",
      "files": [
        {
          "path": "types/oojs-ui/ActionSet.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/ButtonGroupWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/ButtonInputWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/ButtonOptionWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/ButtonWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/CheckboxInputWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/DropdownWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/FieldLayout.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/FieldsetLayout.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/FormLayout.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/HorizontalLayout.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/IconWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/IndexLayout.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/IndicatorWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/InputWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/LabelWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/MenuSelectWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/MessageWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/MultilineTextInputWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/MultioptionWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/MultiselectWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/OptionWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/OutlineControlsWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/PageLayout.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/PopupToolGroup.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/PopupWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/SelectFileWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/SelectWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/StackLayout.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/TabPanelLayout.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/TagItemWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/TagMultiselectWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/TextInputWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/ToggleButtonWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/ToggleWidget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/Tool.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/ToolGroup.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/Toolbar.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/Widget.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/oojs-ui/WindowManager.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "diskdance",
        "ChlodAlejandro"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "oojs",
      "kind": "edit",
      "files": [
        {
          "path": "types/oojs/Registry.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "diskdance",
        "ChlodAlejandro"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "quicksettings",
      "kind": "edit",
      "files": [
        {
          "path": "types/quicksettings/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "janizde"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "rdfjs__namespace",
      "kind": "edit",
      "files": [
        {
          "path": "types/rdfjs__namespace/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "thewilkybarkid",
        "jeswr",
        "tpluscode"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react-instantsearch-core",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-instantsearch-core/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "gburgett",
        "jpowell",
        "davidfurlong",
        "haroenv",
        "samouss"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-reconciler",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-reconciler/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Methuselah96",
        "zhanghaocong",
        "mathieudutour"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-redux",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-redux/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-redux/v6/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tkqubo",
        "clayne11",
        "tansongyang",
        "nicholasboll",
        "mdibyo",
        "val1984",
        "jrakotoharisoa",
        "apapirovski",
        "surgeboris",
        "soerenbf",
        "mrwolfz",
        "dylanvann",
        "Lazyuki",
        "kazuma1989",
        "megazazik",
        "jun-sheaf",
        "phryneas",
        "markerikson"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "react-relay",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-relay/relay-hooks/useLoadMoreFunction.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/relay-hooks/usePaginationFragment.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/relay-hooks/useRefetchableFragment.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/relay-hooks/useRefetchableFragmentNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/relay-hooks/useSubscription.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/v7/lib/relay-experimental/useBlockingPaginationFragment.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/v7/lib/relay-experimental/useLoadMoreFunction.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/v7/lib/relay-experimental/usePaginationFragment.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/v7/lib/relay-experimental/useRefetchableFragment.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/v7/lib/relay-experimental/useRefetchableFragmentNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/v7/lib/relay-experimental/useSubscription.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "alloy",
        "maraisr",
        "edvinerikson",
        "levibuzolic"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "react-sortable-tree",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-sortable-tree/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "wouterhardeman",
        "jzoric",
        "kevinsperrine",
        "acemac",
        "dolezel"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "redux-promise-listener",
      "kind": "edit",
      "files": [
        {
          "path": "types/redux-promise-listener/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "hikiko4ern"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "redux-saga-routines",
      "kind": "edit",
      "files": [
        {
          "path": "types/redux-saga-routines/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "alexey-pelykh"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "redux-sentry-middleware",
      "kind": "edit",
      "files": [
        {
          "path": "types/redux-sentry-middleware/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "dolezel"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "refresh-fetch",
      "kind": "edit",
      "files": [
        {
          "path": "types/refresh-fetch/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "AlexLisenkov",
        "ppbraam"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "relay-runtime",
      "kind": "edit",
      "files": [
        {
          "path": "types/relay-runtime/lib/mutations/commitMutation.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/relay-runtime/lib/subscription/requestSubscription.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "alloy",
        "maraisr",
        "morrys",
        "levibuzolic"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "reservoir",
      "kind": "edit",
      "files": [
        {
          "path": "types/reservoir/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "danvk"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "select2",
      "kind": "edit",
      "files": [
        {
          "path": "types/select2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "borisyankov",
        "denisname"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "stampit",
      "kind": "edit",
      "files": [
        {
          "path": "types/stampit/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "koresar",
        "lummish",
        "popgoesthewza"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "styled-system",
      "kind": "edit",
      "files": [
        {
          "path": "types/styled-system/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "phobon",
        "zephraph",
        "damassi",
        "alloy",
        "maoueh",
        "jschuler",
        "adam187",
        "gretzky",
        "chrislopresto",
        "peduarte",
        "Dhalton",
        "elliotbonneville",
        "jackcaldwell",
        "eliseumds",
        "craga89",
        "HipsterBrown",
        "maddhruv",
        "cherewaty"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "tampermonkey",
      "kind": "edit",
      "files": [
        {
          "path": "types/tampermonkey/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "silverwzw",
        "nikolay-borzov",
        "taozhiyu",
        "double-beep"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "thrift",
      "kind": "edit",
      "files": [
        {
          "path": "types/thrift/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "kamek-pf",
        "kevin-greene-ck",
        "jessezhang91"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "tuya-panel-kit",
      "kind": "edit",
      "files": [
        {
          "path": "types/tuya-panel-kit/@react-navigation/core/types.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/tuya-panel-kit/@react-navigation/core/useNavigationBuilder.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "youngjuning",
        "ShinyLeee"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__blocks",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__blocks/api/factory.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "dsifford",
        "sirreal",
        "dmsnell",
        "tomasztunik",
        "sunyatasattva",
        "bastolen"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__components",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__components/select-control/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "dsifford",
        "sirreal",
        "p-jackson",
        "sarayourfriend",
        "michaelhthomas",
        "manzoorwanijk",
        "bastolen"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__sasl",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__sasl/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "yargs",
      "kind": "edit",
      "files": [
        {
          "path": "types/yargs/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "poelstra",
        "mizunashi-mana",
        "pushplay",
        "JimiC",
        "steffenvv",
        "forivall",
        "ExE-Boss",
        "Aankhen",
        "bcoe"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "johnnyreilly",
      "date": "2023-11-06T18:08:29.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1795762743,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/1225430dfa5cbd8207ecb9098eec8c542d62c7aa/checks?check_suite_id=17950728502"
}

@typescript-bot
Copy link
Contributor

⚠️ There are too many reviewers for this PR change (145). Merging can only be handled by a DT maintainer.

People who would have been pinged wtho ekwoka breeze9527 tpluscode BenjaminHofstetter Ovyerus JasonHK tomwanzek gustavderdrache borisyankov Methuselah96 denisname ledragon rulonder ambar-arkin robertmoura lal12 mateusz-meller micksatana samijaber JoseLion dwrss andoshin11 BendingBender leonard-thieu choffmeister Steve-Fenton Diullei tasoili seanski Guuz ksummerlin basarat nwolverson derekcicerone AndrewGaspar seikichi benjaminjackman JoshStrobl johnnyreilly DickvdBrink King2500 terrymun martin-badin princefishthrower artemiswkearney staticfunction pscanf peterblazejewicz corentinverpillat alexk111 Shaquu diskdance ChlodAlejandro janizde thewilkybarkid jeswr gburgett jpowell davidfurlong haroenv samouss zhanghaocong mathieudutour tkqubo clayne11 tansongyang nicholasboll mdibyo val1984 jrakotoharisoa apapirovski surgeboris soerenbf mrwolfz dylanvann Lazyuki kazuma1989 megazazik jun-sheaf phryneas markerikson alloy maraisr edvinerikson levibuzolic wouterhardeman jzoric kevinsperrine acemac dolezel hikiko4ern alexey-pelykh AlexLisenkov ppbraam morrys danvk koresar lummish popgoesthewza phobon zephraph damassi maoueh jschuler adam187 gretzky chrislopresto peduarte Dhalton elliotbonneville jackcaldwell eliseumds craga89 HipsterBrown maddhruv cherewaty silverwzw nikolay-borzov taozhiyu double-beep kamek-pf kevin-greene-ck jessezhang91 youngjuning ShinyLeee dsifford sirreal dmsnell tomasztunik sunyatasattva bastolen p-jackson sarayourfriend michaelhthomas manzoorwanijk poelstra mizunashi-mana pushplay JimiC steffenvv forivall ExE-Boss Aankhen bcoe

@typescript-bot
Copy link
Contributor

@sandersn The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@sandersn
Copy link
Contributor Author

sandersn commented Nov 6, 2023

The CI failure uncovers a problem with the dependencies that get installed for express types and craco/craco types, but that's a problem on master as well. I'm going to merge this PR to get the overnight runs clean, and then continue investigating the bad dependencies.

@sandersn sandersn merged commit c35ca8d into DefinitelyTyped:master Nov 6, 2023
@sandersn sandersn deleted the update-no-unnecessary-generics-locations branch November 6, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants