fix: react ErrorInfo was missing digest by johnnyreilly · Pull Request #66987 · DefinitelyTyped/DefinitelyTyped

johnnyreilly · 2023-10-09T13:41:34Z

Please fill in this template.

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run npm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
Create it with dts-gen --dt, not by basing it on an existing project.
Represents shape of module/library correctly
tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

Provide a URL to documentation or source code which provides context for the suggested changes: <>
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
Delete the package's directory.
Add it to notNeededPackages.json.

Based on: https://github.com/facebook/react/blob/dddfe688206dafa5646550d351eb9a8e9c53654a/packages/react-reconciler/src/ReactInternalTypes.js#L270-L273

typescript-bot · 2023-10-09T13:42:18Z

@johnnyreilly Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

create-react-class — on npm, on unpkg
react — on npm, on unpkg (author is owner)

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 66987,
  "author": "johnnyreilly",
  "headCommitOid": "e5dea575f2bdb82fcc7b03d1f4fa662d0273c8bb",
  "mergeBaseOid": "29f3f65685aba9e9b8a105a55494923980e2f16e",
  "lastPushDate": "2023-10-09T13:41:34.000Z",
  "lastActivityDate": "2023-10-09T14:46:49.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "create-react-class",
      "kind": "edit",
      "files": [
        {
          "path": "types/create-react-class/create-react-class-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "jgoz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "react",
      "kind": "edit",
      "files": [
        {
          "path": "types/react/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "johnnyreilly",
        "bbenezech",
        "pzavolinsky",
        "ericanderson",
        "DovydasNavickas",
        "theruther4d",
        "guilhermehubner",
        "ferdaber",
        "jrakotoharisoa",
        "pascaloliv",
        "hotell",
        "franklixuefei",
        "Jessidhia",
        "saranshkataria",
        "lukyth",
        "eps1lon",
        "zieka",
        "dancerphil",
        "dimitropoulos",
        "disjukr",
        "vhfmag",
        "hellatan",
        "priyanshurav",
        "Semigradsky"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1753040747,
  "ciResult": "pass"
}

typescript-bot · 2023-10-09T13:42:22Z

🔔 @jgoz @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @eps1lon @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav @Semigradsky — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

typescript-bot · 2023-10-09T14:09:08Z

@johnnyreilly The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

DangerBotOSS · 2023-10-09T14:46:49Z

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

react (`unpkg`)

was missing the following properties:

unstable_act

Generated by 🚫 dangerJS against e5dea57

fix: react ErrorInfo was missing digest

25c18ee

johnnyreilly requested review from Jessidhia and eps1lon as code owners October 9, 2023 13:41

johnnyreilly mentioned this pull request Oct 9, 2023

fix(core): log missing errorInfo in React 18 onRecoverableError callback facebook/docusaurus#9387

Merged

3 tasks

typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests labels Oct 9, 2023

typescript-bot added the The CI failed When GH Actions fails label Oct 9, 2023

fix: create-react-class-tests.ts

e5dea57

typescript-bot added Edits multiple packages and removed Author is Owner The author of this PR is a listed owner of the package. The CI failed When GH Actions fails Untested Change This PR does not touch tests labels Oct 9, 2023

johnnyreilly merged commit 97dc564 into master Oct 9, 2023

johnnyreilly deleted the fix/react-error-info branch October 9, 2023 14:51

eps1lon mentioned this pull request Mar 4, 2024

[react] Sync forks for different TypeScript versions #68890

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: react ErrorInfo was missing digest#66987

fix: react ErrorInfo was missing digest#66987
johnnyreilly merged 2 commits intomasterfrom
fix/react-error-info

johnnyreilly commented Oct 9, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Oct 9, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Oct 9, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Oct 9, 2023

Uh oh!

DangerBotOSS commented Oct 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

johnnyreilly commented Oct 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2 packages in this PR

Code Reviews

Status

Uh oh!

typescript-bot commented Oct 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 9, 2023

Uh oh!

DangerBotOSS commented Oct 9, 2023

react (unpkg)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

johnnyreilly commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading

typescript-bot commented Oct 9, 2023 •

edited

Loading

react (`unpkg`)