Skip to content

Formatted mp4frag with dprint and removed node/buffer import #66834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnnyreilly merged 2 commits into from
Sep 26, 2023
Merged

Formatted mp4frag with dprint and removed node/buffer import #66834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
413e4f7
Formatted mp4frag with dprint
JoshuaKGoldberg Sep 26, 2023
c75fa12
Removed node/buffer import
JoshuaKGoldberg Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .dprint.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
{
"excludes": [
// These files are auto-generated and don't need to be formatted.
// NOTE: We generally prefer that packages be formatted with dprint.
// Packages are generally only listed if they predate our using dprint (August 2023).
// If your package is listed, please consider adding dprint fmt to its generation.
"./types/custom-functions-runtime",
"./types/dojo",
"./types/facebook-nodejs-business-sdk",
"./types/fhir",
"./types/fibjs",
"./types/get-intrinsic",
"./types/locutus",
"./types/lodash",
"./types/material-ui",
"./types/meteor",
"./types/microsoft-graph",
"./types/nginstack__engine",
"./types/node/**/inspector.d.ts",
"./types/office-js-preview",
"./types/office-js",
"./types/office-runtime",
"./types/oibackoff",
"./types/openui5",
"./types/p5",
"./types/react-native",
"./types/sawtooth-sdk",
"./types/three",
"./types/winrt-uwp",
"./types/vscode"
],
"plugins": [
"https://plugins.dprint.dev/typescript-0.85.1.wasm"
],
"indentWidth": 4,
"lineWidth": 120
}
3 changes: 1 addition & 2 deletions types/mp4frag/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
/// <reference types="node" />

import { Transform } from 'stream';
import 'node/buffer';
import { Transform } from "stream";

declare namespace Mp4Frag {
/**
Expand Down
8 changes: 4 additions & 4 deletions types/mp4frag/mp4frag-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Mp4Frag = require('mp4frag');
import Mp4Frag = require("mp4frag");

// $ExpectType Mp4Frag
const m4f = new Mp4Frag({});
Expand All @@ -8,7 +8,7 @@ new Mp4Frag();

// $ExpectType Mp4Frag
new Mp4Frag({
hlsPlaylistBase: 'test',
hlsPlaylistBase: "test",
hlsPlaylistInit: true,
hlsPlaylistExtra: 1,
hlsPlaylistSize: 1,
Expand Down Expand Up @@ -63,7 +63,7 @@ m4f.segmentObjects;
// $ExpectType SegmentObject | null
m4f.getSegmentObject(1);
// $ExpectType SegmentObject | null
m4f.getSegmentObject('1');
m4f.getSegmentObject("1");
// @ts-expect-error
m4f.getSegmentObject(null);

Expand All @@ -81,7 +81,7 @@ const segmentObject = {

// $ExpectType Mp4FragOptions
const mp4FragOptions = {
hlsPlaylistBase: 'abc',
hlsPlaylistBase: "abc",
hlsPlaylistSize: 1,
hlsPlaylistExtra: 1,
hlsPlaylistInit: true,
Expand Down