Disable improved eslint rules #66645

sandersn · 2023-09-08T23:01:55Z

Found by microsoft/DefinitelyTyped-tools#723
microsoft/DefinitelyTyped-tools#724
microsoft/DefinitelyTyped-tools#726

Found by microsoft/DefinitelyTyped-tools#723 microsoft/DefinitelyTyped-tools#724 microsoft/DefinitelyTyped-tools#726

typescript-bot · 2023-09-08T23:02:54Z

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

27 packages in this PR

beyonk__gdpr-cookie-consent-banner — on npm, on unpkg
bluebird — on npm, on unpkg
ember — on npm, on unpkg
ember__application — on npm, on unpkg
ember__array — on npm, on unpkg
ember__component — on npm, on unpkg
ember__engine — on npm, on unpkg
ember__object — on npm, on unpkg
ember__routing — on npm, on unpkg
ember__runloop — on npm, on unpkg
ember__string — on npm, on unpkg
express-useragent — on npm, on unpkg
feathersjs__authentication-client — on npm, on unpkg
feathersjs__authentication-local — on npm, on unpkg
feathersjs__authentication-oauth2 — on npm, on unpkg
jquery — on npm, on unpkg
keystonejs__logger — on npm, on unpkg
leaflet — on npm, on unpkg
mapbox__geojson-area — on npm, on unpkg
mapbox__mapbox-sdk — on npm, on unpkg
mapbox__s3urls — on npm, on unpkg
needle — on npm, on unpkg
novnc__novnc — on npm, on unpkg
ronomon__hash-table — on npm, on unpkg
wordpress__components — on npm, on unpkg
wordpress__rich-text — on npm, on unpkg
yaireo__tagify — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 66645,
  "author": "sandersn",
  "headCommitOid": "f1113fc8791ea4544b8dc3cd5de8c760fa06cf76",
  "mergeBaseOid": "26718139751b01826c4b56cc54c8802a02b85609",
  "lastPushDate": "2023-09-08T23:01:55.000Z",
  "lastActivityDate": "2023-09-11T15:09:41.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "beyonk__gdpr-cookie-consent-banner",
      "kind": "edit",
      "files": [
        {
          "path": "types/beyonk__gdpr-cookie-consent-banner/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "bengry"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "bluebird",
      "kind": "edit",
      "files": [
        {
          "path": "types/bluebird/v2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "lhecker"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "ember",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember/v2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chriskrycho",
        "jamescdavis",
        "wagenet",
        "gitKrystan"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__application",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__application/-private/event-dispatcher.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__application/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chriskrycho",
        "gitKrystan",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__array",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__array/-private/enumerable.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__array/-private/mutable-enumerable.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__array/-private/native-array.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__array/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__array/mutable.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__array/proxy.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__array/types/prototype-extensions.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chriskrycho",
        "gitKrystan",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__component",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__component/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chriskrycho",
        "gitKrystan",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__engine",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__engine/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__engine/instance.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chriskrycho",
        "gitKrystan",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__object",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__object/-private/action-handler.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__object/-private/types.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__object/computed.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__object/core.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__object/evented.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__object/events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__object/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__object/internals.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__object/mixin.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__object/observable.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__object/observers.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__object/promise-proxy-mixin.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__object/proxy.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chriskrycho",
        "gitKrystan",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__routing",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__routing/route.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__routing/router-service.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__routing/router.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chriskrycho",
        "gitKrystan",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__runloop",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__runloop/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chriskrycho",
        "gitKrystan",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__string",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__string/v2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chriskrycho",
        "gitKrystan",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "express-useragent",
      "kind": "edit",
      "files": [
        {
          "path": "types/express-useragent/v0/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "isman-usoh",
        "inglec-arista"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "feathersjs__authentication-client",
      "kind": "edit",
      "files": [
        {
          "path": "types/feathersjs__authentication-client/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "AbraaoAlves",
        "j2L4e"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "feathersjs__authentication-local",
      "kind": "edit",
      "files": [
        {
          "path": "types/feathersjs__authentication-local/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "j2L4e"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "feathersjs__authentication-oauth2",
      "kind": "edit",
      "files": [
        {
          "path": "types/feathersjs__authentication-oauth2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "j2L4e",
        "NickBolles"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "jquery",
      "kind": "edit",
      "files": [
        {
          "path": "types/jquery/v1/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "leonard-thieu",
        "borisyankov",
        "choffmeister",
        "Steve-Fenton",
        "Diullei",
        "tasoili",
        "seanski",
        "Guuz",
        "ksummerlin",
        "basarat",
        "nwolverson",
        "derekcicerone",
        "AndrewGaspar",
        "seikichi",
        "benjaminjackman",
        "JoshStrobl",
        "johnnyreilly",
        "DickvdBrink",
        "King2500",
        "terrymun",
        "martin-badin",
        "princefishthrower"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "keystonejs__logger",
      "kind": "edit",
      "files": [
        {
          "path": "types/keystonejs__logger/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "thekevinbrown",
        "tclain"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "leaflet",
      "kind": "edit",
      "files": [
        {
          "path": "types/leaflet/v0/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "alejo90",
        "atd-schubert",
        "mcauer",
        "ronikar",
        "life777",
        "henrythasler",
        "captain-igloo",
        "someonewithpc"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "mapbox__geojson-area",
      "kind": "edit",
      "files": [
        {
          "path": "types/mapbox__geojson-area/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "n0nick"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mapbox__mapbox-sdk",
      "kind": "edit",
      "files": [
        {
          "path": "types/mapbox__mapbox-sdk/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jeffbdye",
        "mikeomeara1",
        "chachan",
        "techieshark",
        "rroohhh"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mapbox__s3urls",
      "kind": "edit",
      "files": [
        {
          "path": "types/mapbox__s3urls/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "sebastianvera"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "needle",
      "kind": "edit",
      "files": [
        {
          "path": "types/needle/v0/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "bigsan",
        "nikeee",
        "sindilevich",
        "bryanspears"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "novnc__novnc",
      "kind": "edit",
      "files": [
        {
          "path": "types/novnc__novnc/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jakejarvis",
        "ovcharik"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "ronomon__hash-table",
      "kind": "edit",
      "files": [
        {
          "path": "types/ronomon__hash-table/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "airglow923"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__components",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__components/popover/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "dsifford",
        "sirreal",
        "p-jackson",
        "sarayourfriend",
        "michaelhthomas",
        "manzoorwanijk",
        "bastolen"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__rich-text",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__rich-text/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__rich-text/store/actions.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__rich-text/store/selectors.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "dsifford"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "yaireo__tagify",
      "kind": "edit",
      "files": [
        {
          "path": "types/yaireo__tagify/dist/react.tagify.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Brakebein",
        "blutorange"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "JoshuaKGoldberg",
      "date": "2023-09-11T09:55:33.000Z",
      "abbrOid": "1351a39"
    }
  ],
  "mainBotCommentID": 1712318357,
  "ciResult": "pass"
}

typescript-bot · 2023-09-08T23:02:58Z

⚠️ There are too many reviewers for this PR change (66). Merging can only be handled by a DT maintainer.

People who would have been pinged

bengry lhecker chriskrycho jamescdavis wagenet gitKrystan isman-usoh inglec-arista AbraaoAlves j2L4e NickBolles leonard-thieu borisyankov choffmeister Steve-Fenton Diullei tasoili seanski Guuz ksummerlin basarat nwolverson derekcicerone AndrewGaspar seikichi benjaminjackman JoshStrobl johnnyreilly DickvdBrink King2500 terrymun martin-badin princefishthrower thekevinbrown tclain alejo90 atd-schubert mcauer ronikar life777 henrythasler captain-igloo someonewithpc n0nick jeffbdye mikeomeara1 chachan techieshark rroohhh sebastianvera bigsan nikeee sindilevich bryanspears jakejarvis ovcharik airglow923 dsifford sirreal p-jackson sarayourfriend michaelhthomas manzoorwanijk bastolen Brakebein blutorange

typescript-bot · 2023-09-08T23:16:08Z

@sandersn The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

JoshuaKGoldberg

Thanks!

If more of these pop-up I'm ok to continue disabling in the other pull requests too.

DangerBotOSS · 2023-09-11T15:09:41Z

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.