Add missing lint exemptions #66579

sandersn · 2023-09-01T18:41:15Z

These lint rules were recently fixed to be more correct, and now catch problems in old versions and scoped packages.

typescript-bot · 2023-09-01T18:42:13Z

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

32 packages in this PR

auth0-js — on npm, on unpkg
bluebird — on npm, on unpkg
ember__application — on npm, on unpkg
- Config files to check:
  - ember__application/v3/.eslintrc.json: edited
ember__array — on npm, on unpkg
- Config files to check:
  - ember__array/v3/.eslintrc.json: edited
ember__component — on npm, on unpkg
- Config files to check:
  - ember__component/v3/.eslintrc.json: edited
ember__engine — on npm, on unpkg
- Config files to check:
  - ember__engine/v3/.eslintrc.json: edited
ember__object — on npm, on unpkg
- Config files to check:
  - ember__object/v3/.eslintrc.json: edited
ember__routing — on npm, on unpkg
- Config files to check:
  - ember__routing/v3/.eslintrc.json: edited
ember__runloop — on npm, on unpkg
- Config files to check:
  - ember__runloop/v3/.eslintrc.json: edited
feathersjs__authentication-jwt — on npm, on unpkg
feathersjs__authentication-oauth1 — on npm, on unpkg
feathersjs__authentication — on npm, on unpkg
feathersjs__express — on npm, on unpkg
google-cloud__datastore — on npm, on unpkg
- Config files to check:
  - google-cloud__datastore/.eslintrc.json: edited
hapi — on npm, on unpkg
hapi__catbox-redis — on npm, on unpkg
humblebee__styled-components-breakpoint — on npm, on unpkg
isomorphic-git__lightning-fs — on npm, on unpkg
jquery — on npm, on unpkg
keystonejs__email — on npm, on unpkg
keystonejs__session — on npm, on unpkg
mapbox__shelf-pack — on npm, on unpkg
needle — on npm, on unpkg
node-notifier — on npm, on unpkg
openlayers — on npm, on unpkg
parse — on npm, on unpkg
rbush — on npm, on unpkg
riderize__passport-strava-oauth2 — on npm, on unpkg
stampit — on npm, on unpkg
wordpress__blocks — on npm, on unpkg
wordpress__editor — on npm, on unpkg
wordpress__notices — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 66579,
  "author": "sandersn",
  "headCommitOid": "c7fb5f388c7dcb27402f486457d8820c4db03193",
  "mergeBaseOid": "95859b661dfcb16451d7afbf3605189c170cc002",
  "lastPushDate": "2023-09-01T18:41:15.000Z",
  "lastActivityDate": "2023-09-01T18:54:10.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "auth0-js",
      "kind": "edit",
      "files": [
        {
          "path": "types/auth0-js/v7/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "adrianchia",
        "mdurrant",
        "peterblazejewicz",
        "bkotrys",
        "marknelissen",
        "tylerlindell",
        "hequ"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "bluebird",
      "kind": "edit",
      "files": [
        {
          "path": "types/bluebird/v1/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "lhecker"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "ember__application",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__application/v3/.eslintrc.json",
          "kind": "package-meta",
          "suspect": "edited"
        }
      ],
      "owners": [
        "chriskrycho",
        "gitKrystan",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__array",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__array/v3/.eslintrc.json",
          "kind": "package-meta",
          "suspect": "edited"
        }
      ],
      "owners": [
        "chriskrycho",
        "gitKrystan",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__component",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__component/v3/.eslintrc.json",
          "kind": "package-meta",
          "suspect": "edited"
        }
      ],
      "owners": [
        "chriskrycho",
        "gitKrystan",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__engine",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__engine/v3/.eslintrc.json",
          "kind": "package-meta",
          "suspect": "edited"
        }
      ],
      "owners": [
        "chriskrycho",
        "gitKrystan",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__object",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__object/v3/.eslintrc.json",
          "kind": "package-meta",
          "suspect": "edited"
        }
      ],
      "owners": [
        "chriskrycho",
        "gitKrystan",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__routing",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__routing/v3/.eslintrc.json",
          "kind": "package-meta",
          "suspect": "edited"
        }
      ],
      "owners": [
        "chriskrycho",
        "gitKrystan",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__runloop",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__runloop/v3/.eslintrc.json",
          "kind": "package-meta",
          "suspect": "edited"
        }
      ],
      "owners": [
        "chriskrycho",
        "gitKrystan",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "feathersjs__authentication-jwt",
      "kind": "edit",
      "files": [
        {
          "path": "types/feathersjs__authentication-jwt/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "j2L4e"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "feathersjs__authentication-oauth1",
      "kind": "edit",
      "files": [
        {
          "path": "types/feathersjs__authentication-oauth1/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "j2L4e"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "feathersjs__authentication",
      "kind": "edit",
      "files": [
        {
          "path": "types/feathersjs__authentication/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "AbraaoAlves",
        "j2L4e",
        "NickBolles"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "feathersjs__express",
      "kind": "edit",
      "files": [
        {
          "path": "types/feathersjs__express/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "j2L4e",
        "DadUndead"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "google-cloud__datastore",
      "kind": "edit",
      "files": [
        {
          "path": "types/google-cloud__datastore/.eslintrc.json",
          "kind": "package-meta",
          "suspect": "edited"
        }
      ],
      "owners": [
        "beaulac",
        "ogawa0071",
        "ThomasdenH"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "hapi",
      "kind": "edit",
      "files": [
        {
          "path": "types/hapi/v12/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "rafaelsouzaf",
        "jhsimms",
        "SimonSchick",
        "saboya"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "hapi__catbox-redis",
      "kind": "edit",
      "files": [
        {
          "path": "types/hapi__catbox-redis/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "SimonSchick",
        "lenovouser"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "humblebee__styled-components-breakpoint",
      "kind": "edit",
      "files": [
        {
          "path": "types/humblebee__styled-components-breakpoint/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "CarlRibbegaardh"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "isomorphic-git__lightning-fs",
      "kind": "edit",
      "files": [
        {
          "path": "types/isomorphic-git__lightning-fs/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "DefinitelyTyped"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "jquery",
      "kind": "edit",
      "files": [
        {
          "path": "types/jquery/v2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "leonard-thieu",
        "borisyankov",
        "choffmeister",
        "Steve-Fenton",
        "Diullei",
        "tasoili",
        "seanski",
        "Guuz",
        "ksummerlin",
        "basarat",
        "nwolverson",
        "derekcicerone",
        "AndrewGaspar",
        "seikichi",
        "benjaminjackman",
        "JoshStrobl",
        "johnnyreilly",
        "DickvdBrink",
        "King2500",
        "terrymun",
        "martin-badin",
        "princefishthrower"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "keystonejs__email",
      "kind": "edit",
      "files": [
        {
          "path": "types/keystonejs__email/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "thekevinbrown",
        "tclain"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "keystonejs__session",
      "kind": "edit",
      "files": [
        {
          "path": "types/keystonejs__session/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "thekevinbrown",
        "tclain"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mapbox__shelf-pack",
      "kind": "edit",
      "files": [
        {
          "path": "types/mapbox__shelf-pack/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Perlmint"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "needle",
      "kind": "edit",
      "files": [
        {
          "path": "types/needle/v1/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "bigsan",
        "nikeee",
        "sindilevich",
        "bryanspears"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "node-notifier",
      "kind": "edit",
      "files": [
        {
          "path": "types/node-notifier/v5/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tkQubo",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "openlayers",
      "kind": "edit",
      "files": [
        {
          "path": "types/openlayers/v3/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "osechet",
        "wb14123",
        "mylen",
        "iamthechad",
        "danmana",
        "yairtawil",
        "pierremarc",
        "hauke96",
        "gberaudo"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "parse",
      "kind": "edit",
      "files": [
        {
          "path": "types/parse/v1/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ullisenmedia",
        "dpoetzsch",
        "jaeggerr",
        "flavionegrao",
        "wesleygrimes",
        "owsas",
        "agoldis",
        "AlexandreHetu",
        "dplewis",
        "yomybaby",
        "pocketcolin",
        "rdhelms",
        "jlnquere",
        "tybi",
        "jeffgukang",
        "buitanloc",
        "JeromeDeLeon",
        "kentrh",
        "swittk"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "rbush",
      "kind": "edit",
      "files": [
        {
          "path": "types/rbush/v2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "danvk",
        "cmslewis"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "riderize__passport-strava-oauth2",
      "kind": "edit",
      "files": [
        {
          "path": "types/riderize__passport-strava-oauth2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "edilson"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "stampit",
      "kind": "edit",
      "files": [
        {
          "path": "types/stampit/v2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "koresar",
        "lummish",
        "popgoesthewza"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__blocks",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__blocks/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "dsifford",
        "sirreal",
        "dmsnell",
        "tomasztunik",
        "sunyatasattva",
        "bastolen"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__editor",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__editor/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "dsifford"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "wordpress__notices",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__notices/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "dsifford",
        "chihsuan"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1703182595,
  "ciResult": "pass"
}

typescript-bot · 2023-09-01T18:42:17Z

⚠️ There are too many reviewers for this PR change (97). Merging can only be handled by a DT maintainer.

People who would have been pinged

adrianchia mdurrant peterblazejewicz bkotrys marknelissen tylerlindell hequ lhecker chriskrycho gitKrystan jamescdavis wagenet j2L4e AbraaoAlves NickBolles DadUndead beaulac ogawa0071 ThomasdenH rafaelsouzaf jhsimms SimonSchick saboya lenovouser CarlRibbegaardh DefinitelyTyped leonard-thieu borisyankov choffmeister Steve-Fenton Diullei tasoili seanski Guuz ksummerlin basarat nwolverson derekcicerone AndrewGaspar seikichi benjaminjackman JoshStrobl johnnyreilly DickvdBrink King2500 terrymun martin-badin princefishthrower thekevinbrown tclain Perlmint bigsan nikeee sindilevich bryanspears tkQubo osechet wb14123 mylen iamthechad danmana yairtawil pierremarc hauke96 gberaudo ullisenmedia dpoetzsch jaeggerr flavionegrao wesleygrimes owsas agoldis AlexandreHetu dplewis yomybaby pocketcolin rdhelms jlnquere tybi jeffgukang buitanloc JeromeDeLeon kentrh swittk danvk cmslewis edilson koresar lummish popgoesthewza dsifford sirreal dmsnell tomasztunik sunyatasattva bastolen chihsuan

typescript-bot · 2023-09-01T18:42:19Z