Formatted types/x* packages with dprint #66545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

typescript-bot merged 1 commit into DefinitelyTyped:master from JoshuaKGoldberg:dprint-fmt-x

Aug 30, 2023

Collaborator

JoshuaKGoldberg commented Aug 30, 2023

👉 Partial implementation of #65993. If you're seeing this and are surprised it's happening, please read the discussion and give feedback! ❤️

Implements the dprint formatting changes on packages whose names start with x. We're splitting up the changes to make it a bit easier to apply & review them en masse - and, if we need later on, revert / bisect for issues. These changes generated with roughly:

git checkout dprint-onboarding -- .dprint.jsonc
time npx dprint fmt "types/x*/**/*.t*"
# Formatted 166 files.
npx dprint fmt "types/x*/**/*.t*"  2.19s user 0.53s system 166% cpu 1.625 total
rm .dprint.jsonc

CI failures are due to DefinitelyTyped-tools > feat: remove formatting rules rules from dtslint not being ~~merged~~ included in CI yet.


          Formatted types/x* packages with dprint

1cc3c60

DangerBotOSS commented Aug 30, 2023

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

xdate (`unpkg`)

was missing the following properties:

parsers

xhook (`unpkg`)

was missing the following properties:

addEventListener
removeEventListener
dispatchEvent
listeners
on

as well as these 8 other properties...

off, fire, once, destroy, EventEmitter, XMLHttpRequest, fetch, headers

xml-escape (`unpkg`)

was missing the following properties:

map

xmlhttprequest (`unpkg`)

was missing the following properties:

XMLHttpRequest

xmljs (`unpkg`)

was missing the following properties:

extend
override

xmpp__error (`unpkg`)

was missing the following properties:

captureStackTrace
prepareStackTrace
stackTraceLimit
captureStackTrace
prepareStackTrace

as well as these 4 other properties...

stackTraceLimit, captureStackTrace, prepareStackTrace, stackTraceLimit

xsalsa20 (`unpkg`)

was missing the following properties:

core_hsalsa20
SIGMA

xsd-schema-validator (`unpkg`)

was missing the following properties:

The declaration doesn't match the JavaScript module 'xsd-schema-validator'. Reason:
The JavaScript module can be called or constructed, but the declaration module cannot.

The most common way to resolve this error is to use 'export =' syntax.
To learn more about 'export =' syntax, see https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require.

xstyled__styled-components (`unpkg`)

was missing the following properties:

StyleSheetConsumer
StyleSheetContext
StyleSheetConsumer
StyleSheetContext

xstyled__system (`unpkg`)

was missing the following properties:

createStyleGenerator
getBreakpoints
reduceBreakpoints
themeGetter
createStyleGenerator

as well as these 3 other properties...

getBreakpoints, reduceBreakpoints, themeGetter

Generated by 🚫 dangerJS against 1cc3c60

JoshuaKGoldberg marked this pull request as ready for review

August 30, 2023 13:03

JoshuaKGoldberg requested a review from peterblazejewicz as a code owner

August 30, 2023 13:03

Contributor

typescript-bot commented Aug 30, 2023 •

edited

Loading

@JoshuaKGoldberg Thank you for submitting this PR!

This is a live comment which I will keep updated.

73 packages in this PR

x-axios-progress-bar — on npm, on unpkg
x-editable — on npm, on unpkg
x-ray-crawler — on npm, on unpkg
x-ray — on npm, on unpkg
x509.js — on npm, on unpkg
xar — on npm, on unpkg
xast — on npm, on unpkg
xdate — on npm, on unpkg
xdomain — on npm, on unpkg
xelib — on npm, on unpkg
xhook — on npm, on unpkg
xk6-sql-browser — on npm, on unpkg
xml-c14n — on npm, on unpkg
xml-crypto — on npm, on unpkg
xml-encryption — on npm, on unpkg
xml-escape — on npm, on unpkg
xml-flow — on npm, on unpkg
xml-name-validator — on npm, on unpkg
xml-parser — on npm, on unpkg
xml-zero-lexer — on npm, on unpkg
xml — on npm, on unpkg
xml2js — on npm, on unpkg
xml2json — on npm, on unpkg
xmldoc — on npm, on unpkg
xmldom — on npm, on unpkg
xmlhttprequest — on npm, on unpkg
xmljs — on npm, on unpkg
xmlpoke — on npm, on unpkg
xmlrpc — on npm, on unpkg
xmlserializer — on npm, on unpkg
xmltojson — on npm, on unpkg
xmpp__base64 — on npm, on unpkg
xmpp__client-core — on npm, on unpkg
xmpp__client — on npm, on unpkg
xmpp__component-core — on npm, on unpkg
xmpp__component — on npm, on unpkg
xmpp__connection-tcp — on npm, on unpkg
xmpp__connection — on npm, on unpkg
xmpp__debug — on npm, on unpkg
xmpp__error — on npm, on unpkg
xmpp__events — on npm, on unpkg
xmpp__id — on npm, on unpkg
xmpp__iq — on npm, on unpkg
xmpp__jid — on npm, on unpkg
xmpp__middleware — on npm, on unpkg
xmpp__reconnect — on npm, on unpkg
xmpp__resolve — on npm, on unpkg
xmpp__resource-binding — on npm, on unpkg
xmpp__sasl-anonymous — on npm, on unpkg
xmpp__sasl-plain — on npm, on unpkg
xmpp__sasl-scram-sha-1 — on npm, on unpkg
xmpp__sasl — on npm, on unpkg
xmpp__session-establishment — on npm, on unpkg
xmpp__starttls — on npm, on unpkg
xmpp__stream-features — on npm, on unpkg
xmpp__stream-management — on npm, on unpkg
xmpp__tcp — on npm, on unpkg
xmpp__time — on npm, on unpkg
xmpp__tls — on npm, on unpkg
xmpp__uri — on npm, on unpkg
xmpp__websocket — on npm, on unpkg
xmpp__xml — on npm, on unpkg
xo — on npm, on unpkg
xrm — on npm, on unpkg
xsalsa20-encoding — on npm, on unpkg
xsalsa20 — on npm, on unpkg
xsd-schema-validator — on npm, on unpkg
xsockets — on npm, on unpkg
xss-filters — on npm, on unpkg
xstyled__styled-components — on npm, on unpkg
xstyled__system — on npm, on unpkg
xtend — on npm, on unpkg
xxhashjs — on npm, on unpkg

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
✅ A DT maintainer needs to approve changes which affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 66545,
  "author": "JoshuaKGoldberg",
  "headCommitOid": "1cc3c603473bcbcc5d791ec0c9367ac75499706f",
  "mergeBaseOid": "1f7d4dd1b69889f8b0f81f7bc7a36fdec9c5395f",
  "lastPushDate": "2023-08-30T04:26:31.000Z",
  "lastActivityDate": "2023-08-30T16:28:00.000Z",
  "mergeOfferDate": "2023-08-30T16:27:01.000Z",
  "mergeRequestDate": "2023-08-30T16:28:00.000Z",
  "mergeRequestUser": "JoshuaKGoldberg",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": true,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "x-axios-progress-bar",
      "kind": "edit",
      "files": [
        {
          "path": "types/x-axios-progress-bar/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "caugner"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "x-editable",
      "kind": "edit",
      "files": [
        {
          "path": "types/x-editable/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/x-editable/x-editable-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "sirkirby"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "x-ray-crawler",
      "kind": "edit",
      "files": [
        {
          "path": "types/x-ray-crawler/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/x-ray-crawler/x-ray-crawler-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "mtraynham"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "x-ray",
      "kind": "edit",
      "files": [
        {
          "path": "types/x-ray/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/x-ray/x-ray-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "mtraynham"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "x509.js",
      "kind": "edit",
      "files": [
        {
          "path": "types/x509.js/x509.js-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Moser-ss"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xar",
      "kind": "edit",
      "files": [
        {
          "path": "types/xar/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xar/xar-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "ffflorian"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xast",
      "kind": "edit",
      "files": [
        {
          "path": "types/xast/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xast/v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xast/v1/xast-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/xast/xast-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "stefanprobst",
        "wooorm",
        "ChristianMurphy",
        "rokt33r",
        "remcohaszing"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xdate",
      "kind": "edit",
      "files": [
        {
          "path": "types/xdate/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xdate/xdate-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "yamada28go"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "xdomain",
      "kind": "edit",
      "files": [
        {
          "path": "types/xdomain/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xdomain/xdomain-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xelib",
      "kind": "edit",
      "files": [
        {
          "path": "types/xelib/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xelib/xelib-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "awlayton"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xhook",
      "kind": "edit",
      "files": [
        {
          "path": "types/xhook/xhook-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "artfuldev"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xk6-sql-browser",
      "kind": "edit",
      "files": [
        {
          "path": "types/xk6-sql-browser/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xk6-sql-browser/xk6-sql-browser-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "leandrodotec"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xml-c14n",
      "kind": "edit",
      "files": [
        {
          "path": "types/xml-c14n/xml-c14n-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "gallowsmaker",
        "maxbogus"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xml-crypto",
      "kind": "edit",
      "files": [
        {
          "path": "types/xml-crypto/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xml-crypto/xml-crypto-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "eheikes",
        "maxchehab"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "xml-encryption",
      "kind": "edit",
      "files": [
        {
          "path": "types/xml-encryption/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xml-encryption/xml-encryption-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "midgleyc"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "xml-escape",
      "kind": "edit",
      "files": [
        {
          "path": "types/xml-escape/xml-escape-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "DefinitelyTyped"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xml-flow",
      "kind": "edit",
      "files": [
        {
          "path": "types/xml-flow/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xml-flow/xml-flow-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Warerebel"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xml-name-validator",
      "kind": "edit",
      "files": [
        {
          "path": "types/xml-name-validator/xml-name-validator-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "doug-wade"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xml-parser",
      "kind": "edit",
      "files": [
        {
          "path": "types/xml-parser/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xml-parser/xml-parser-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "mhfrantz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xml-zero-lexer",
      "kind": "edit",
      "files": [
        {
          "path": "types/xml-zero-lexer/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xml-zero-lexer/xml-zero-lexer-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "943297456"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xml",
      "kind": "edit",
      "files": [
        {
          "path": "types/xml/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xml/xml-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "YuJianrong",
        "semyonf"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xml2js",
      "kind": "edit",
      "files": [
        {
          "path": "types/xml2js/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xml2js/xml2js-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "michelsalib",
        "jasonrm",
        "ccurrens",
        "edwardhinkle",
        "claasahl",
        "redlickigrzegorz",
        "72636c"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "xml2json",
      "kind": "edit",
      "files": [
        {
          "path": "types/xml2json/xml2json-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "dolanmiu",
        "xamgore"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmldoc",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmldoc/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmldoc/xmldoc-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Xstoudi",
        "ajsheehan",
        "notlaforge"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmldom",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmldom/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmldom/xmldom-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "tkqubo",
        "karfau"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "xmlhttprequest",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmlhttprequest/xmlhttprequest-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "CruseCtrl"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmljs",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmljs/xmljs-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "blackshadev"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmlpoke",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmlpoke/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmlpoke/xmlpoke-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "garthk"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmlrpc",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmlrpc/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmlrpc/xmlrpc-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmlserializer",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmlserializer/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmlserializer/xmlserializer-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "eoin-obrien"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmltojson",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmltojson/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmltojson/xmltojson-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "traviscrowe"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__base64",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__base64/xmpp__base64-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__client-core",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__client-core/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__client-core/lib/Client.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__client-core/xmpp__client-core-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__client",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__client/browser.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__client/dist/xmpp.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__client/dist/xmpp.min.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__client/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__client/react-native.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__client/test/xmpp__client-bundle.ts",
          "kind": "test"
        },
        {
          "path": "types/xmpp__client/test/xmpp__client.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__component-core",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__component-core/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__component-core/lib/Component.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__component-core/xmpp__component-core-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__component",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__component/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__component/xmpp__component-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__connection-tcp",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__connection-tcp/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__connection-tcp/xmpp__connection-tcp-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__connection",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__connection/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__connection/lib/StreamError.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__connection/lib/util.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__connection/xmpp__connection-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__debug",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__debug/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__debug/xmpp__debug-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__error",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__error/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__error/xmpp__error-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__events",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__events/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__events/xmpp__events-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__id",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__id/xmpp__id-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__iq",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__iq/callee.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__iq/caller.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__iq/xmpp__iq-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__jid",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__jid/xmpp__jid-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__middleware",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__middleware/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__middleware/lib/Context.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__middleware/lib/IncomingContext.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__middleware/lib/OutgoingContext.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__middleware/lib/StanzaError.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__middleware/xmpp__middleware-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__reconnect",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__reconnect/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__reconnect/xmpp__reconnect-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__resolve",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__resolve/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__resolve/lib/alt-connections.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__resolve/lib/dns.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__resolve/resolve.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__resolve/xmpp__resolve-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__resource-binding",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__resource-binding/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__resource-binding/xmpp__resource-binding-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__sasl-anonymous",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__sasl-anonymous/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__sasl-anonymous/xmpp__sasl-anonymous-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__sasl-plain",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__sasl-plain/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__sasl-plain/xmpp__sasl-plain-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__sasl-scram-sha-1",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__sasl-scram-sha-1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__sasl-scram-sha-1/xmpp__sasl-scram-sha-1-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__sasl",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__sasl/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__sasl/lib/SASLError.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__sasl/xmpp__sasl-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__session-establishment",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__session-establishment/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__session-establishment/xmpp__session-establishment-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__starttls",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__starttls/client.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__starttls/starttls.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__starttls/xmpp__starttls-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__stream-features",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__stream-features/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__stream-features/route.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__stream-features/xmpp__stream-features-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__stream-management",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__stream-management/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__stream-management/xmpp__stream-management-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__tcp",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__tcp/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__tcp/lib/Connection.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__tcp/xmpp__tcp-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__time",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__time/xmpp__time-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__tls",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__tls/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__tls/lib/Connection.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__tls/lib/Socket.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__tls/xmpp__tls-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__uri",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__uri/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__uri/xmpp__uri-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__websocket",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__websocket/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__websocket/lib/Connection.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__websocket/lib/FramedParser.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__websocket/lib/Socket.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__websocket/xmpp__websocket-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xmpp__xml",
      "kind": "edit",
      "files": [
        {
          "path": "types/xmpp__xml/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xmpp__xml/xmpp__xml-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/xmpp__xml/xmpp__xml-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xo",
      "kind": "edit",
      "files": [
        {
          "path": "types/xo/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xo/xo-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "peterblazejewicz",
        "shian15810"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xrm",
      "kind": "edit",
      "files": [
        {
          "path": "types/xrm/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xrm/v6/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xrm/v6/xrm-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/xrm/v7/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xrm/v7/parature.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xrm/v7/xrm-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/xrm/v8/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xrm/v8/xrm-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/xrm/xrm-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "mattngan",
        "markusmauch",
        "daryllabar",
        "clownwilleatme",
        "scottdurow",
        "filcole",
        "power-maverick"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xsalsa20-encoding",
      "kind": "edit",
      "files": [
        {
          "path": "types/xsalsa20-encoding/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xsalsa20-encoding/xsalsa20-encoding-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xsalsa20",
      "kind": "edit",
      "files": [
        {
          "path": "types/xsalsa20/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xsd-schema-validator",
      "kind": "edit",
      "files": [
        {
          "path": "types/xsd-schema-validator/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xsd-schema-validator/xsd-schema-validator-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Goldsmith42"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xsockets",
      "kind": "edit",
      "files": [
        {
          "path": "types/xsockets/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xsockets/xsockets-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "pushplay"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xss-filters",
      "kind": "edit",
      "files": [
        {
          "path": "types/xss-filters/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xss-filters/xss-filters-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xstyled__styled-components",
      "kind": "edit",
      "files": [
        {
          "path": "types/xstyled__styled-components/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xstyled__styled-components/xstyled__styled-components-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "good-idea"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xstyled__system",
      "kind": "edit",
      "files": [
        {
          "path": "types/xstyled__system/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xstyled__system/xstyled__system-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "stevejay"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xtend",
      "kind": "edit",
      "files": [
        {
          "path": "types/xtend/xtend-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "rhysd"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "xxhashjs",
      "kind": "edit",
      "files": [
        {
          "path": "types/xxhashjs/xxhashjs-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "mDibyo",
        "Manc"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2023-08-30T16:19:02.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1699132449,
  "ciResult": "pass"
}

typescript-bot added Popular package Edits multiple packages Too Many Owners Huge Change labels

Contributor

typescript-bot commented Aug 30, 2023

⚠️ There are too many reviewers for this PR change (62). Merging can only be handled by a DT maintainer.

People who would have been pinged

caugner sirkirby mtraynham Moser-ss ffflorian stefanprobst wooorm ChristianMurphy rokt33r remcohaszing yamada28go awlayton artfuldev leandrodotec gallowsmaker maxbogus eheikes maxchehab midgleyc DefinitelyTyped Warerebel doug-wade mhfrantz 943297456 YuJianrong semyonf michelsalib jasonrm ccurrens edwardhinkle claasahl redlickigrzegorz 72636c dolanmiu xamgore Xstoudi ajsheehan notlaforge tkqubo karfau CruseCtrl blackshadev garthk eoin-obrien traviscrowe BendingBender peterblazejewicz shian15810 mattngan markusmauch daryllabar clownwilleatme scottdurow filcole power-maverick Goldsmith42 pushplay good-idea stevejay rhysd mDibyo Manc

sandersn approved these changes

View reviewed changes

typescript-bot added Maintainer Approved Self Merge labels

Contributor

typescript-bot commented Aug 30, 2023

@JoshuaKGoldberg: Everything looks good here. I am ready to merge this PR (at 1cc3c60) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

Collaborator Author

JoshuaKGoldberg commented Aug 30, 2023

Ready to merge

typescript-bot merged commit 841bf96 into DefinitelyTyped:master

JoshuaKGoldberg deleted the dprint-fmt-x branch

August 30, 2023 16:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Edits multiple packages Huge Change Maintainer Approved Popular package Self Merge Too Many Owners