Formatted types/q* packages with dprint #66538

JoshuaKGoldberg · 2023-08-30T04:20:37Z

👉 Partial implementation of #65993. If you're seeing this and are surprised it's happening, please read the discussion and give feedback! ❤️

Implements the dprint formatting changes on packages whose names start with q. We're splitting up the changes to make it a bit easier to apply & review them en masse - and, if we need later on, revert / bisect for issues. These changes generated with roughly:

git checkout dprint-onboarding -- .dprint.jsonc
time npx dprint fmt "types/q*/**/*.t*"
# Formatted 59 files.
# npx dprint fmt "types/q*/**/*.t*"  2.20s user 0.50s system 166% cpu 1.622 total
rm .dprint.jsonc

DangerBotOSS · 2023-08-30T14:25:29Z

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

q (`unpkg`)

was missing the following properties:

promise
passByCopy
join
makePromise
tap

as well as these 28 other properties...

thenResolve, thenReject, resetUnhandledRejections, getUnhandledReasons, stopUnhandledRejectionTracking, fulfill, master, spawn, return, dispatch, get, set, del, delete, mapply, post, fapply, keys, any, fail, catch, progress, fin, finally, done, nmapply, nmcall, nodeify

qs (`unpkg`)

was missing the following properties:

formats

Generated by 🚫 dangerJS against c22faff

typescript-bot · 2023-08-30T14:49:12Z

@JoshuaKGoldberg Thank you for submitting this PR!

This is a live comment which I will keep updated.

29 packages in this PR

q-io — on npm, on unpkg
q-retry — on npm, on unpkg
q — on npm, on unpkg
qbittorrent-api-v2 — on npm, on unpkg
qlik-engineapi — on npm, on unpkg
qlik-visualizationextensions — on npm, on unpkg
qr-image — on npm, on unpkg
qrcode-svg — on npm, on unpkg
qrcode.react — on npm, on unpkg
qrcode — on npm, on unpkg
qrcodejs — on npm, on unpkg
qs-middleware — on npm, on unpkg
qs — on npm, on unpkg
qtip2 — on npm, on unpkg
quantize — on npm, on unpkg
quaternion — on npm, on unpkg
query-selector-shadow-dom — on npm, on unpkg
query-string-params — on npm, on unpkg
querystringify — on npm, on unpkg
quick-format-unescaped — on npm, on unpkg
quick-hash — on npm, on unpkg
quick-picker — on npm, on unpkg
quick-store — on npm, on unpkg
quicklink — on npm, on unpkg
quicksettings — on npm, on unpkg
quill — on npm, on unpkg
quixote — on npm, on unpkg
qunit — on npm, on unpkg
qwest — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
✅ A DT maintainer needs to approve changes which affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 66538,
  "author": "JoshuaKGoldberg",
  "headCommitOid": "c22faff861720ad12a8876131dddc2bb05a9d740",
  "mergeBaseOid": "1f7d4dd1b69889f8b0f81f7bc7a36fdec9c5395f",
  "lastPushDate": "2023-08-30T04:20:37.000Z",
  "lastActivityDate": "2023-08-30T18:24:06.000Z",
  "mergeOfferDate": "2023-08-30T16:25:09.000Z",
  "mergeRequestDate": "2023-08-30T18:24:06.000Z",
  "mergeRequestUser": "JoshuaKGoldberg",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": true,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "q-io",
      "kind": "edit",
      "files": [
        {
          "path": "types/q-io/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/q-io/q-io-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Bartvds"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "q-retry",
      "kind": "edit",
      "files": [
        {
          "path": "types/q-retry/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/q-retry/q-retry-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "vilic"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "q",
      "kind": "edit",
      "files": [
        {
          "path": "types/q/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/q/q-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/q/v0/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/q/v0/q-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "bnemetchek",
        "AndrewGaspar",
        "johnnyreilly",
        "mboudreau",
        "TeamworkGuy2"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "qbittorrent-api-v2",
      "kind": "edit",
      "files": [
        {
          "path": "types/qbittorrent-api-v2/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qbittorrent-api-v2/qbittorrent-api-v2-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Totto16"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "qlik-engineapi",
      "kind": "edit",
      "files": [
        {
          "path": "types/qlik-engineapi/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "konne",
        "richardison"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "qlik-visualizationextensions",
      "kind": "edit",
      "files": [
        {
          "path": "types/qlik-visualizationextensions/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "konne"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "qr-image",
      "kind": "edit",
      "files": [
        {
          "path": "types/qr-image/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qr-image/qr-image-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "taoqf"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "qrcode-svg",
      "kind": "edit",
      "files": [
        {
          "path": "types/qrcode-svg/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qrcode-svg/qrcode-svg-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "ericbf"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "qrcode.react",
      "kind": "edit",
      "files": [
        {
          "path": "types/qrcode.react/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qrcode.react/qrcode.react-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "mleko",
        "yonasadiel",
        "bjoluc"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "qrcode",
      "kind": "edit",
      "files": [
        {
          "path": "types/qrcode/build/qrcode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qrcode/build/qrcode.tosjis.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qrcode/helper/to-sjis.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qrcode/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qrcode/test/qrcode-browser-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/qrcode/test/qrcode-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "plantain-00",
        "mnahkies",
        "Marchelune",
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "qrcodejs",
      "kind": "edit",
      "files": [
        {
          "path": "types/qrcodejs/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qrcodejs/qrcodejs-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "qs-middleware",
      "kind": "edit",
      "files": [
        {
          "path": "types/qs-middleware/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qs-middleware/qs-middleware-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "davecardwell"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "qs",
      "kind": "edit",
      "files": [
        {
          "path": "types/qs/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qs/qs-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "RWander",
        "leonyu",
        "tehbelinda",
        "zyml",
        "artursvonda",
        "CarlosBonetti",
        "dpsmith3",
        "hperrin",
        "ljharb"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "qtip2",
      "kind": "edit",
      "files": [
        {
          "path": "types/qtip2/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qtip2/qtip2-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Seltzer",
        "leonard-thieu"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "quantize",
      "kind": "edit",
      "files": [
        {
          "path": "types/quantize/quantize-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "matiand"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "quaternion",
      "kind": "edit",
      "files": [
        {
          "path": "types/quaternion/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/quaternion/quaternion-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "yannbriancon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "query-selector-shadow-dom",
      "kind": "edit",
      "files": [
        {
          "path": "types/query-selector-shadow-dom/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/query-selector-shadow-dom/query-selector-shadow-dom-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "davidalvarezr"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "query-string-params",
      "kind": "edit",
      "files": [
        {
          "path": "types/query-string-params/query-string-params-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "bansalrachita"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "querystringify",
      "kind": "edit",
      "files": [
        {
          "path": "types/querystringify/querystringify-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "ilich"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "quick-format-unescaped",
      "kind": "edit",
      "files": [
        {
          "path": "types/quick-format-unescaped/quick-format-unescaped-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "AdamVig"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "quick-hash",
      "kind": "edit",
      "files": [
        {
          "path": "types/quick-hash/quick-hash-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "ffflorian"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "quick-picker",
      "kind": "edit",
      "files": [
        {
          "path": "types/quick-picker/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/quick-picker/quick-picker-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "illestomas"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "quick-store",
      "kind": "edit",
      "files": [
        {
          "path": "types/quick-store/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/quick-store/quick-store-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "promise"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "quicklink",
      "kind": "edit",
      "files": [
        {
          "path": "types/quicklink/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/quicklink/quicklink-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Pimm"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "quicksettings",
      "kind": "edit",
      "files": [
        {
          "path": "types/quicksettings/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/quicksettings/quicksettings-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "janizde"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "quill",
      "kind": "edit",
      "files": [
        {
          "path": "types/quill/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/quill/quill-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "sumitkm",
        "guillaume-ro-fr",
        "43081j",
        "AnielloFalcone",
        "mhamri",
        "TheLand",
        "AmeerHamoodi"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "quixote",
      "kind": "edit",
      "files": [
        {
          "path": "types/quixote/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/quixote/quixote-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "greybax"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "qunit",
      "kind": "edit",
      "files": [
        {
          "path": "types/qunit/test/global-test.ts",
          "kind": "test"
        },
        {
          "path": "types/qunit/test/module-test.ts",
          "kind": "test"
        },
        {
          "path": "types/qunit/v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qunit/v1/qunit-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "waratuman",
        "mike-north",
        "sechel",
        "chriskrycho",
        "gitKrystan",
        "jamescdavis",
        "Krinkle"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "qwest",
      "kind": "edit",
      "files": [
        {
          "path": "types/qwest/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qwest/qwest-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "lindsayevans"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2023-08-30T16:16:02.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1699330508,
  "ciResult": "pass"
}

typescript-bot · 2023-08-30T14:49:15Z

⚠️ There are too many reviewers for this PR change (59). Merging can only be handled by a DT maintainer.

People who would have been pinged

Bartvds vilic bnemetchek AndrewGaspar johnnyreilly mboudreau TeamworkGuy2 Totto16 konne richardison taoqf ericbf mleko yonasadiel bjoluc plantain-00 mnahkies Marchelune BendingBender peterblazejewicz davecardwell RWander leonyu tehbelinda zyml artursvonda CarlosBonetti dpsmith3 hperrin ljharb Seltzer leonard-thieu matiand yannbriancon davidalvarezr bansalrachita ilich AdamVig ffflorian illestomas promise Pimm janizde sumitkm guillaume-ro-fr 43081j AnielloFalcone mhamri TheLand AmeerHamoodi greybax waratuman mike-north sechel chriskrycho gitKrystan jamescdavis Krinkle lindsayevans

typescript-bot · 2023-08-30T14:49:18Z

@JoshuaKGoldberg Thank you for submitting this PR!

This is a live comment which I will keep updated.

29 packages in this PR

q-io — on npm, on unpkg
q-retry — on npm, on unpkg
q — on npm, on unpkg
qbittorrent-api-v2 — on npm, on unpkg
qlik-engineapi — on npm, on unpkg
qlik-visualizationextensions — on npm, on unpkg
qr-image — on npm, on unpkg
qrcode-svg — on npm, on unpkg
qrcode.react — on npm, on unpkg
qrcode — on npm, on unpkg
qrcodejs — on npm, on unpkg
qs-middleware — on npm, on unpkg
qs — on npm, on unpkg
qtip2 — on npm, on unpkg
quantize — on npm, on unpkg
quaternion — on npm, on unpkg
query-selector-shadow-dom — on npm, on unpkg
query-string-params — on npm, on unpkg
querystringify — on npm, on unpkg
quick-format-unescaped — on npm, on unpkg
quick-hash — on npm, on unpkg
quick-picker — on npm, on unpkg
quick-store — on npm, on unpkg
quicklink — on npm, on unpkg
quicksettings — on npm, on unpkg
quill — on npm, on unpkg
quixote — on npm, on unpkg
qunit — on npm, on unpkg
qwest — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
✅ A DT maintainer needs to approve changes which affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 66538,
  "author": "JoshuaKGoldberg",
  "headCommitOid": "c22faff861720ad12a8876131dddc2bb05a9d740",
  "mergeBaseOid": "1f7d4dd1b69889f8b0f81f7bc7a36fdec9c5395f",
  "lastPushDate": "2023-08-30T04:20:37.000Z",
  "lastActivityDate": "2023-08-30T18:24:06.000Z",
  "mergeOfferDate": "2023-08-30T16:25:09.000Z",
  "mergeRequestDate": "2023-08-30T18:24:06.000Z",
  "mergeRequestUser": "JoshuaKGoldberg",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": true,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "q-io",
      "kind": "edit",
      "files": [
        {
          "path": "types/q-io/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/q-io/q-io-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Bartvds"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "q-retry",
      "kind": "edit",
      "files": [
        {
          "path": "types/q-retry/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/q-retry/q-retry-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "vilic"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "q",
      "kind": "edit",
      "files": [
        {
          "path": "types/q/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/q/q-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/q/v0/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/q/v0/q-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "bnemetchek",
        "AndrewGaspar",
        "johnnyreilly",
        "mboudreau",
        "TeamworkGuy2"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "qbittorrent-api-v2",
      "kind": "edit",
      "files": [
        {
          "path": "types/qbittorrent-api-v2/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qbittorrent-api-v2/qbittorrent-api-v2-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Totto16"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "qlik-engineapi",
      "kind": "edit",
      "files": [
        {
          "path": "types/qlik-engineapi/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "konne",
        "richardison"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "qlik-visualizationextensions",
      "kind": "edit",
      "files": [
        {
          "path": "types/qlik-visualizationextensions/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "konne"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "qr-image",
      "kind": "edit",
      "files": [
        {
          "path": "types/qr-image/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qr-image/qr-image-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "taoqf"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "qrcode-svg",
      "kind": "edit",
      "files": [
        {
          "path": "types/qrcode-svg/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qrcode-svg/qrcode-svg-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "ericbf"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "qrcode.react",
      "kind": "edit",
      "files": [
        {
          "path": "types/qrcode.react/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qrcode.react/qrcode.react-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "mleko",
        "yonasadiel",
        "bjoluc"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "qrcode",
      "kind": "edit",
      "files": [
        {
          "path": "types/qrcode/build/qrcode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qrcode/build/qrcode.tosjis.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qrcode/helper/to-sjis.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qrcode/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qrcode/test/qrcode-browser-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/qrcode/test/qrcode-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "plantain-00",
        "mnahkies",
        "Marchelune",
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "qrcodejs",
      "kind": "edit",
      "files": [
        {
          "path": "types/qrcodejs/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qrcodejs/qrcodejs-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "qs-middleware",
      "kind": "edit",
      "files": [
        {
          "path": "types/qs-middleware/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qs-middleware/qs-middleware-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "davecardwell"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "qs",
      "kind": "edit",
      "files": [
        {
          "path": "types/qs/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qs/qs-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "RWander",
        "leonyu",
        "tehbelinda",
        "zyml",
        "artursvonda",
        "CarlosBonetti",
        "dpsmith3",
        "hperrin",
        "ljharb"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "qtip2",
      "kind": "edit",
      "files": [
        {
          "path": "types/qtip2/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qtip2/qtip2-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Seltzer",
        "leonard-thieu"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "quantize",
      "kind": "edit",
      "files": [
        {
          "path": "types/quantize/quantize-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "matiand"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "quaternion",
      "kind": "edit",
      "files": [
        {
          "path": "types/quaternion/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/quaternion/quaternion-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "yannbriancon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "query-selector-shadow-dom",
      "kind": "edit",
      "files": [
        {
          "path": "types/query-selector-shadow-dom/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/query-selector-shadow-dom/query-selector-shadow-dom-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "davidalvarezr"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "query-string-params",
      "kind": "edit",
      "files": [
        {
          "path": "types/query-string-params/query-string-params-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "bansalrachita"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "querystringify",
      "kind": "edit",
      "files": [
        {
          "path": "types/querystringify/querystringify-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "ilich"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "quick-format-unescaped",
      "kind": "edit",
      "files": [
        {
          "path": "types/quick-format-unescaped/quick-format-unescaped-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "AdamVig"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "quick-hash",
      "kind": "edit",
      "files": [
        {
          "path": "types/quick-hash/quick-hash-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "ffflorian"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "quick-picker",
      "kind": "edit",
      "files": [
        {
          "path": "types/quick-picker/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/quick-picker/quick-picker-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "illestomas"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "quick-store",
      "kind": "edit",
      "files": [
        {
          "path": "types/quick-store/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/quick-store/quick-store-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "promise"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "quicklink",
      "kind": "edit",
      "files": [
        {
          "path": "types/quicklink/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/quicklink/quicklink-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Pimm"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "quicksettings",
      "kind": "edit",
      "files": [
        {
          "path": "types/quicksettings/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/quicksettings/quicksettings-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "janizde"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "quill",
      "kind": "edit",
      "files": [
        {
          "path": "types/quill/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/quill/quill-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "sumitkm",
        "guillaume-ro-fr",
        "43081j",
        "AnielloFalcone",
        "mhamri",
        "TheLand",
        "AmeerHamoodi"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "quixote",
      "kind": "edit",
      "files": [
        {
          "path": "types/quixote/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/quixote/quixote-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "greybax"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "qunit",
      "kind": "edit",
      "files": [
        {
          "path": "types/qunit/test/global-test.ts",
          "kind": "test"
        },
        {
          "path": "types/qunit/test/module-test.ts",
          "kind": "test"
        },
        {
          "path": "types/qunit/v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qunit/v1/qunit-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "waratuman",
        "mike-north",
        "sechel",
        "chriskrycho",
        "gitKrystan",
        "jamescdavis",
        "Krinkle"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "qwest",
      "kind": "edit",
      "files": [
        {
          "path": "types/qwest/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/qwest/qwest-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "lindsayevans"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2023-08-30T16:16:02.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1699330508,
  "ciResult": "pass"
}

typescript-bot · 2023-08-30T14:49:21Z

⚠️ There are too many reviewers for this PR change (59). Merging can only be handled by a DT maintainer.

People who would have been pinged

Bartvds vilic bnemetchek AndrewGaspar johnnyreilly mboudreau TeamworkGuy2 Totto16 konne richardison taoqf ericbf mleko yonasadiel bjoluc plantain-00 mnahkies Marchelune BendingBender peterblazejewicz davecardwell RWander leonyu tehbelinda zyml artursvonda CarlosBonetti dpsmith3 hperrin ljharb Seltzer leonard-thieu matiand yannbriancon davidalvarezr bansalrachita ilich AdamVig ffflorian illestomas promise Pimm janizde sumitkm guillaume-ro-fr 43081j AnielloFalcone mhamri TheLand AmeerHamoodi greybax waratuman mike-north sechel chriskrycho gitKrystan jamescdavis Krinkle lindsayevans

typescript-bot · 2023-08-30T16:25:09Z

@JoshuaKGoldberg: Everything looks good here. I am ready to merge this PR (at c22faff) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

JoshuaKGoldberg · 2023-08-30T16:28:05Z

Ready to merge

JoshuaKGoldberg · 2023-08-30T18:24:06Z

Ready to merge

JoshuaKGoldberg added 2 commits August 29, 2023 23:58

Formatted types/q* packages with dprint

f59595b

Fixed introduced issues

c22faff

JoshuaKGoldberg marked this pull request as ready for review August 30, 2023 14:48

JoshuaKGoldberg requested review from Bartvds, Diullei, johnnyreilly and peterblazejewicz as code owners August 30, 2023 14:48

typescript-bot added Critical package Edits multiple packages Too Many Owners Huge Change labels Aug 30, 2023

sandersn approved these changes Aug 30, 2023

View reviewed changes

typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Aug 30, 2023

typescript-bot merged commit 7e3ed21 into DefinitelyTyped:master Aug 30, 2023

JoshuaKGoldberg deleted the dprint-fmt-q branch August 30, 2023 18:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Formatted types/q* packages with dprint #66538

Formatted types/q* packages with dprint #66538

Uh oh!

JoshuaKGoldberg commented Aug 30, 2023 •

edited

Loading

Uh oh!

DangerBotOSS commented Aug 30, 2023

Uh oh!

typescript-bot commented Aug 30, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Aug 30, 2023

Uh oh!

typescript-bot commented Aug 30, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Aug 30, 2023

Uh oh!

typescript-bot commented Aug 30, 2023

Uh oh!

JoshuaKGoldberg commented Aug 30, 2023

Uh oh!

JoshuaKGoldberg commented Aug 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Formatted types/q* packages with dprint #66538

Formatted types/q* packages with dprint #66538

Uh oh!

Conversation

JoshuaKGoldberg commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DangerBotOSS commented Aug 30, 2023

q (unpkg)

qs (unpkg)

Uh oh!

typescript-bot commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

29 packages in this PR

Code Reviews

Status

Uh oh!

typescript-bot commented Aug 30, 2023

Uh oh!

typescript-bot commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

29 packages in this PR

Code Reviews

Status

Uh oh!

typescript-bot commented Aug 30, 2023

Uh oh!

typescript-bot commented Aug 30, 2023

Uh oh!

JoshuaKGoldberg commented Aug 30, 2023

Uh oh!

JoshuaKGoldberg commented Aug 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JoshuaKGoldberg commented Aug 30, 2023 •

edited

Loading

q (`unpkg`)

qs (`unpkg`)

typescript-bot commented Aug 30, 2023 •

edited

Loading

typescript-bot commented Aug 30, 2023 •

edited

Loading