[aws-sdk2-types] ran dprint fmt #66360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@JoshuaKGoldberg Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66360,
"author": "JoshuaKGoldberg",
"headCommitOid": "b7d1a8b9828e4e22ff89089a3781435c91883823",
"mergeBaseOid": "77fd45a8acc24b0134624306b279fa45cdec09b3",
"lastPushDate": "2023-08-11T18:23:51.000Z",
"lastActivityDate": "2023-08-12T14:13:35.000Z",
"mergeOfferDate": "2023-08-12T14:12:50.000Z",
"mergeRequestDate": "2023-08-12T14:13:35.000Z",
"mergeRequestUser": "JoshuaKGoldberg",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": true,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "aws-sdk2-types",
"kind": "edit",
"files": [
{
"path": "types/aws-sdk2-types/aws-sdk2-types-tests.ts",
"kind": "test"
},
{
"path": "types/aws-sdk2-types/clients/dynamodb.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/clients/rdsdataservice.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/clients/s3.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/clients/ses.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/clients/sqs.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/clients/ssm.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/index.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/config-base.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/config.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/config_service_placeholders.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/config_use_dualstack.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/core.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/credentials.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/credentials/credential_provider_chain.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/credentials/ec2_metadata_credentials.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/credentials/ecs_credentials.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/credentials/environment_credentials.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/credentials/file_system_credentials.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/credentials/process_credentials.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/credentials/remote_credentials.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/credentials/saml_credentials.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/credentials/shared_ini_file_credentials.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/credentials/token_file_web_identity_credentials.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/dynamodb/converter.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/dynamodb/document_client.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/endpoint.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/error.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/event-stream/event-stream.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/event_listeners.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/http_request.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/http_response.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/metadata_service.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/request.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/response.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/s3/managed_upload.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/s3/presigned_post.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/service.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/services/dynamodb.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/services/s3.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/shared-ini/ini-loader.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/token.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/token/sso_token_provider.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/token/static_token_provider.d.ts",
"kind": "definition"
},
{
"path": "types/aws-sdk2-types/lib/token/token_provider_chain.d.ts",
"kind": "definition"
}
],
"owners": [
"aws",
"sandersn"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sandersn",
"date": "2023-08-11T21:02:11.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1675196400,
"ciResult": "pass"
} |
Contributor
|
🔔 @aws @sandersn — please review this PR in the next few days. Be sure to explicitly select |
sandersn
approved these changes
Aug 11, 2023
Contributor
sandersn
left a comment
There was a problem hiding this comment.
This package is a manual clone of just the parts of aws-sdk that are used by (old) types packages on DT. Realistically, it's never going to change, so it's fine to format it.
Collaborator
Author
|
Great thanks - in that case I'll close this out and let it be done by the main commit. |
Collaborator
Author
|
Actually - instead of closing these individual ones out I'm going to start merging them in individually. That way we can get early testing of formatted packages, and revert individually if we need. |
Collaborator
Author
|
Ready to merge |
Contributor
|
@JoshuaKGoldberg: Everything looks good here. I am ready to merge this PR (at b7d1a8b) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
Contributor
|
🛂 Hi @JoshuaKGoldberg, I can't accept a pull request until all of the checks in the "Status" section of this comment are green. I will let you know once that happens. Thanks, and happy typing! |
Collaborator
Author
|
Ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hi! This PR is meant to let you know that we're going to be applying formatting automatically to all DefinitelyTyped packages1. This PR is split out of:
This package is particularly huge (>1MB), so we're tagging you in an individual PR as a heads up. Please post here to let us know if you have any workflow needs that auto-formatting might disrupt2.
Cheers! 💖
Footnotes
Note that formatting will be applied as a commit to
masterafter each PR. PRs won't be blocked on any CI check for proper formatting. See Using a formatter for formatting (instead of lint rules) #65993 for more information. ↩For example, if this package is fully auto-generated (rather than manually edited), subsequent PRs might have a lot of noise from formatting differences. We can exclude it from formatting in that case. ↩