[google-apps-script] ran dprint fmt #66356

JoshuaKGoldberg · 2023-08-11T18:21:34Z

👋 Hi! This PR is meant to let you know that we're going to be applying formatting automatically to all DefinitelyTyped packages¹. This PR is split out of:

Using a formatter for formatting (instead of lint rules) #65993: the discussion that includes backing context and our planned approach
Added dprint config and commit-on-master task #66235: onboards the repository to dprint

This package is particularly huge (>1MB), so we're tagging you in an individual PR as a heads up. Please post here to let us know if you have any workflow needs that auto-formatting might disrupt².

Cheers! 💖

time npx dprint fmt types/google-apps-script/**/*.t*
Formatted 61 files.
npx dprint fmt types/google-apps-script/**/*.t*  1.19s user 0.34s system 177% cpu 0.865 total

Note that formatting will be applied as a commit to master after each PR. PRs won't be blocked on any CI check for proper formatting. See Using a formatter for formatting (instead of lint rules) #65993 for more information. ↩
For example, if this package is fully auto-generated (rather than manually edited), subsequent PRs might have a lot of noise from formatting differences. We can exclude it from formatting in that case. ↩

typescript-bot · 2023-08-11T18:22:16Z

@JoshuaKGoldberg Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

google-apps-script — on npm, on unpkg
lodash-es — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

❌ No merge conflicts
✅ Continuous integration tests have passed
🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 23 days — it is considered nearly abandoned!

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 66356,
  "author": "JoshuaKGoldberg",
  "headCommitOid": "bf577c2507d2c817c8f768a5210335d489802e28",
  "mergeBaseOid": "dfc258b892794239a47ca9bef558214109884695",
  "lastPushDate": "2023-08-11T18:21:34.000Z",
  "lastActivityDate": "2023-08-29T15:44:57.000Z",
  "hasMergeConflict": true,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": true,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "google-apps-script",
      "kind": "edit",
      "files": [
        {
          "path": "types/google-apps-script/apis/adsense_v1_4.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/analytics_v3.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/analyticsreporting_v4.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/appsactivity_v1.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/bigquery_v2.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/calendar_v3.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/classroom_v1.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/content_v2.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/dfareporting_v3_3.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/directory_v1.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/docs_v1.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/drive_v2.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/driveactivity_v2.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/gmail_v1.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/groupsmigration_v1.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/groupssettings_v1.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/licensing_v1.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/mirror_v1.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/peopleapi_v1.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/reports_v1.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/reseller_v1.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/sheets_v4.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/slides_v1.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/tagmanager_v2.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/tasks_v1.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/youtube_v3.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/youtubeanalytics_v2.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/apis/youtubepartner_v1.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script-events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.base.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.cache.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.calendar.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.card-service.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.charts.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.conference-data.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.contacts.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.content.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.data-studio.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.document.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.drive.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.forms.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.gmail.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.groups.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.html.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.jdbc.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.language.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.lock.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.mail.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.maps.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.optimization.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.properties.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.script.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.sites.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.slides.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.spreadsheet.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.types.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.url-fetch.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.utilities.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/google-apps-script.xml-service.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-apps-script/test/google-apps-script-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/google-apps-script/test/google-apps-script-tests.with-node.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "PopGoesTheWza",
        "motemen",
        "pierluigi-montagna",
        "mtgto"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "lodash-es",
      "kind": "edit",
      "files": [
        {
          "path": "types/lodash-es/array.default.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/lodash-es/collection.default.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/lodash-es/date.default.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/lodash-es/debounce.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/lodash-es/function.default.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/lodash-es/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/lodash-es/lang.default.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/lodash-es/lodash-es-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/lodash-es/math.default.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/lodash-es/number.default.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/lodash-es/object.default.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/lodash-es/scripts/generate-modules.ts",
          "kind": "test"
        },
        {
          "path": "types/lodash-es/string.default.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/lodash-es/util.default.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "stephenlautier",
        "e-cloud"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1675194228,
  "ciResult": "pass"
}

typescript-bot · 2023-08-11T18:22:19Z

🔔 @PopGoesTheWza @motemen @pierluigi-montagna @mtgto @stephenlautier @e-cloud — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

mtgto · 2023-08-11T23:34:08Z

I'm an active maintainer of types/google-apps-script. I understand your detailed explanation.

Please post here to let us know if you have any workflow needs that auto-formatting might disrupt

This package was originally auto-generated by those tools but hasn't been used for updates.
So you don't have to worry about it.

Thanks.

JoshuaKGoldberg · 2023-08-12T00:53:55Z

Ah great! In that case I think we can close this out and let it be formatted in the main commit that formats everything. Thanks!

JoshuaKGoldberg · 2023-08-12T14:12:37Z

Actually - instead of closing these individual ones out I'm going to start merging them in individually. That way we can get early testing of formatted packages, and revert individually if we need.

Could I ask you to approve the PR please?

typescript-bot · 2023-08-16T01:04:16Z

@JoshuaKGoldberg Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

typescript-bot · 2023-08-29T15:03:50Z

@JoshuaKGoldberg Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

typescript-bot · 2023-08-29T15:39:57Z

Re-ping @PopGoesTheWza, @motemen, @pierluigi-montagna, @mtgto, @stephenlautier, @e-cloud:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

typescript-bot · 2023-08-29T15:40:05Z

Re-ping @PopGoesTheWza, @motemen, @pierluigi-montagna, @mtgto, @stephenlautier, @e-cloud:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

DangerBotOSS · 2023-08-29T15:44:57Z

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

lodash-es (`unpkg`)

was missing the following properties:

commit
lodash
next
plant
thru

as well as these 13 other properties...

toIterator, toJSON, value, valueOf, wrapperAt, wrapperChain, wrapperCommit, wrapperLodash, wrapperNext, wrapperPlant, wrapperReverse, wrapperToIterator, wrapperValue

Generated by 🚫 dangerJS against bf577c2

typescript-bot · 2023-08-29T18:50:12Z

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @JoshuaKGoldberg.

(Ping @PopGoesTheWza, @motemen, @pierluigi-montagna, @mtgto, @stephenlautier, @e-cloud.)

typescript-bot · 2023-08-31T01:51:28Z

@JoshuaKGoldberg Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

typescript-bot · 2023-09-21T18:58:03Z

@JoshuaKGoldberg I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Sep 28th (in a week) if the issues aren't addressed.

JoshuaKGoldberg · 2023-09-21T18:58:52Z

#66528 was merged, so we can close this out. ✅

[google-apps-script] ran dprint fmt

6e6dffb

typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Huge Change labels Aug 11, 2023

JoshuaKGoldberg closed this Aug 12, 2023

JoshuaKGoldberg deleted the dprint-google-apps-script branch August 12, 2023 00:53

JoshuaKGoldberg restored the dprint-google-apps-script branch August 12, 2023 14:12

JoshuaKGoldberg reopened this Aug 12, 2023

typescript-bot added the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Aug 16, 2023

Updating dprint settings to latest

7dee55a

JoshuaKGoldberg added 2 commits August 29, 2023 11:39

Merge branch 'master'

fa7c3c2

Updating dprint settings to latest

306b56f

Updating dprint settings to latest

bf577c2

JoshuaKGoldberg mentioned this pull request Aug 30, 2023

Formatted types/g* packages with dprint #66528

Merged

typescript-bot added the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Aug 31, 2023

typescript-bot removed the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Aug 31, 2023

typescript-bot added the Abandoned This PR had no activity for a long time, and is considered abandoned label Sep 21, 2023

JoshuaKGoldberg closed this Sep 21, 2023

JoshuaKGoldberg deleted the dprint-google-apps-script branch September 21, 2023 18:58

[google-apps-script] ran dprint fmt #66356

[google-apps-script] ran dprint fmt #66356

Uh oh!

Conversation

JoshuaKGoldberg commented Aug 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Footnotes

Uh oh!

typescript-bot commented Aug 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2 packages in this PR

Code Reviews

Status

Inactive

Uh oh!

typescript-bot commented Aug 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtgto commented Aug 11, 2023

Uh oh!

JoshuaKGoldberg commented Aug 12, 2023

Uh oh!

JoshuaKGoldberg commented Aug 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 16, 2023

Uh oh!

typescript-bot commented Aug 29, 2023

Uh oh!

typescript-bot commented Aug 29, 2023

Uh oh!

typescript-bot commented Aug 29, 2023

Uh oh!

DangerBotOSS commented Aug 29, 2023

lodash-es (unpkg)

Uh oh!

typescript-bot commented Aug 29, 2023

Uh oh!

typescript-bot commented Aug 31, 2023

Uh oh!

typescript-bot commented Sep 21, 2023

Uh oh!

JoshuaKGoldberg commented Sep 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JoshuaKGoldberg commented Aug 11, 2023 •

edited

Loading

typescript-bot commented Aug 11, 2023 •

edited

Loading

typescript-bot commented Aug 11, 2023 •

edited

Loading

JoshuaKGoldberg commented Aug 12, 2023 •

edited

Loading

lodash-es (`unpkg`)