-
Notifications
You must be signed in to change notification settings - Fork 30.5k
[microsoft-graph] ran dprint fmt #66354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[microsoft-graph] ran dprint fmt #66354
Conversation
|
@JoshuaKGoldberg Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66354,
"author": "JoshuaKGoldberg",
"headCommitOid": "10b476d33d44434b8f3ef292b1a8ebbc15d65800",
"mergeBaseOid": "77fd45a8acc24b0134624306b279fa45cdec09b3",
"lastPushDate": "2023-08-11T18:21:32.000Z",
"lastActivityDate": "2023-08-11T19:51:11.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": true,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "microsoft-graph",
"kind": "edit",
"files": [
{
"path": "types/microsoft-graph/index.d.ts",
"kind": "definition"
},
{
"path": "types/microsoft-graph/microsoft-graph-tests.ts",
"kind": "test"
}
],
"owners": [
"microsoftgraph",
"MIchaelMainer",
"koros",
"zengin",
"ddyett",
"gavinbarron"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 1675194225,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/10b476d33d44434b8f3ef292b1a8ebbc15d65800/checks?check_suite_id=15025770038"
} |
|
🔔 @microsoftgraph @MIchaelMainer @koros @zengin @ddyett @gavinbarron — please review this PR in the next few days. Be sure to explicitly select |
|
@JoshuaKGoldberg The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
1 similar comment
|
@JoshuaKGoldberg The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
This changes auto generated files, which will be overriden by next generation. @koros, can we incorporate these styling rules in the auto generation output? |
👋 Hi! This PR is meant to let you know that we're going to be applying formatting automatically to all DefinitelyTyped packages1. This PR is split out of:
This package is particularly huge (>1MB), so we're tagging you in an individual PR as a heads up. Please post here to let us know if you have any workflow needs that auto-formatting might disrupt2.
Cheers! 💖
Footnotes
Note that formatting will be applied as a commit to
masterafter each PR. PRs won't be blocked on any CI check for proper formatting. See Using a formatter for formatting (instead of lint rules) #65993 for more information. ↩For example, if this package is fully auto-generated (rather than manually edited), subsequent PRs might have a lot of noise from formatting differences. We can exclude it from formatting in that case. ↩