[react] ran dprint fmt #66352

JoshuaKGoldberg · 2023-08-11T18:21:31Z

👋 Hi! This PR is meant to let you know that we're going to be applying formatting automatically to all DefinitelyTyped packages¹. This PR is split out of:

Using a formatter for formatting (instead of lint rules) #65993: the discussion that includes backing context and our planned approach
Added dprint config and commit-on-master task #66235: onboards the repository to dprint

This package is particularly huge (>1MB), so we're tagging you in an individual PR as a heads up. Please post here to let us know if you have any workflow needs that auto-formatting might disrupt².

Cheers! 💖

time npx dprint fmt types/react/**/*.t*       
Formatted 49 files.
npx dprint fmt types/react/**/*.t*  1.09s user 0.29s system 182% cpu 0.762 total

Note that formatting will be applied as a commit to master after each PR. PRs won't be blocked on any CI check for proper formatting. See Using a formatter for formatting (instead of lint rules) #65993 for more information. ↩
For example, if this package is fully auto-generated (rather than manually edited), subsequent PRs might have a lot of noise from formatting differences. We can exclude it from formatting in that case. ↩

typescript-bot · 2023-08-11T18:22:13Z

@JoshuaKGoldberg Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

react — on npm, on unpkg
- owner-approval: @johnnyreilly

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
❌ Continuous integration tests have failed
✅ Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 66352,
  "author": "JoshuaKGoldberg",
  "headCommitOid": "95ef91c7185ca39bdf66122148856896f8cc2832",
  "mergeBaseOid": "dfc258b892794239a47ca9bef558214109884695",
  "lastPushDate": "2023-08-11T18:21:31.000Z",
  "lastActivityDate": "2023-09-26T13:43:11.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": true,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react",
      "kind": "edit",
      "files": [
        {
          "path": "types/react/canary.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/experimental.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/global.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/jsx-dev-runtime.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/jsx-runtime.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/test/canary.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/test/cssProperties.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/test/elementAttributes.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/test/experimental.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/test/hooks.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/test/index.ts",
          "kind": "test"
        },
        {
          "path": "types/react/test/managedAttributes.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/test/tsx.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/ts5.0/canary.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/ts5.0/experimental.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/ts5.0/global.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/ts5.0/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/ts5.0/jsx-dev-runtime.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/ts5.0/jsx-runtime.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/ts5.0/test/canary.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/ts5.0/test/cssProperties.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/ts5.0/test/elementAttributes.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/ts5.0/test/experimental.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/ts5.0/test/hooks.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/ts5.0/test/index.ts",
          "kind": "test"
        },
        {
          "path": "types/react/ts5.0/test/managedAttributes.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/ts5.0/test/tsx.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v15/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v15/jsx-dev-runtime.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v15/jsx-runtime.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v15/test/cssProperties.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v15/test/index.ts",
          "kind": "test"
        },
        {
          "path": "types/react/v15/test/tsx.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v16/global.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v16/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v16/jsx-dev-runtime.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v16/jsx-runtime.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v16/test/cssProperties.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v16/test/elementAttributes.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v16/test/hooks.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v16/test/index.ts",
          "kind": "test"
        },
        {
          "path": "types/react/v16/test/managedAttributes.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v16/test/tsx.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v17/global.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v17/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v17/jsx-dev-runtime.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v17/jsx-runtime.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v17/test/cssProperties.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v17/test/elementAttributes.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v17/test/hooks.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v17/test/index.ts",
          "kind": "test"
        },
        {
          "path": "types/react/v17/test/managedAttributes.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v17/test/tsx.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "johnnyreilly",
        "bbenezech",
        "pzavolinsky",
        "ericanderson",
        "DovydasNavickas",
        "theruther4d",
        "guilhermehubner",
        "ferdaber",
        "jrakotoharisoa",
        "pascaloliv",
        "hotell",
        "franklixuefei",
        "Jessidhia",
        "saranshkataria",
        "lukyth",
        "eps1lon",
        "zieka",
        "dancerphil",
        "dimitropoulos",
        "disjukr",
        "vhfmag",
        "hellatan",
        "priyanshurav",
        "Semigradsky"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2023-09-26T13:43:11.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "johnnyreilly",
      "date": "2023-09-26T13:31:21.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "jakebailey",
      "date": "2023-08-11T18:54:00.000Z",
      "abbrOid": "19a4cdb"
    }
  ],
  "mainBotCommentID": 1675194156,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/95ef91c7185ca39bdf66122148856896f8cc2832/checks?check_suite_id=15610278988"
}

typescript-bot · 2023-08-11T18:22:16Z

🔔 @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @eps1lon @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav @Semigradsky — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

types/react/test/elementAttributes.tsx

typescript-bot · 2023-08-11T18:54:41Z

@JoshuaKGoldberg The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot · 2023-08-29T14:47:06Z

Re-ping @johnnyreilly, @bbenezech, @pzavolinsky, @ericanderson, @DovydasNavickas, @theruther4d, @guilhermehubner, @ferdaber, @jrakotoharisoa, @pascaloliv, @Hotell, @franklixuefei, @Jessidhia, @saranshkataria, @lukyth, @eps1lon, @zieka, @dancerphil, @dimitropoulos, @disjukr, @vhfmag, @hellatan, @priyanshurav, @Semigradsky:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

typescript-bot · 2023-08-29T15:20:03Z

@JoshuaKGoldberg The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot · 2023-08-29T16:06:19Z

@JoshuaKGoldberg The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot · 2023-09-04T01:08:12Z

@JoshuaKGoldberg I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Sep 10th (in a week) if the issues aren't addressed.

typescript-bot · 2023-09-12T01:29:30Z

@JoshuaKGoldberg To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!

jakebailey · 2023-09-12T01:33:17Z

Bad bot

DangerBotOSS · 2023-09-12T01:57:47Z

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

react (`unpkg`)

was missing the following properties:

unstable_act

Generated by 🚫 dangerJS against 95ef91c

JoshuaKGoldberg added 17 commits July 31, 2023 11:55

[WIP] Onboarded to dprint

784770e

Switch to useTabs: true in nested configurations

c0ac60c

Remove overrides for non-tabs files

e0613af

Switch trailingCommas to onlyMultiline

6b0bbb1

onlyMultiLine

7afbce5

Reduce to just TypeScript files

dd37ed2

Remove nested dprint.json files

7e7210e

Added initial sketch of workflows

5063543

Added documentation and .vscode/settings.json formatting

f4b4c3c

Move non-TS-specific settings to root of dprint.json

78a486a

Also format-and-commit on master pushes

04822ea

Workflow fixes: master, and run summary

0544423

Added concurrency to format-and-commit.yml

8575cc9

Allowed just root-level .vscode/settings.json in root-level .gitignore

12772a4

Added remaining generated packages to excludes

f86762f

Remaining feedback: ordering, and comment master push trigger for now

796e225

[react] ran dprint fmt

19a4cdb

JoshuaKGoldberg requested review from Jessidhia, eps1lon and johnnyreilly as code owners August 11, 2023 18:21

typescript-bot added Critical package Huge Change labels Aug 11, 2023

JoshuaKGoldberg added 3 commits August 11, 2023 14:29

Add .vscode/extensions.json too

7871f3e

Use cache, and TS preferred config name

806888e

no ci

cf692cc

jakebailey reviewed Aug 11, 2023

View reviewed changes

types/react/test/elementAttributes.tsx Outdated Show resolved Hide resolved

typescript-bot added the The CI failed When GH Actions fails label Aug 11, 2023

typescript-bot added Edits Infrastructure Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. and removed The CI failed When GH Actions fails labels Aug 29, 2023

Undo additions from dprint-onboarding

aaf4ad5

typescript-bot added The CI failed When GH Actions fails and removed Edits Infrastructure Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Aug 29, 2023

Manually correct ts-expect-error directives

95ef91c

typescript-bot added Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. The CI failed When GH Actions fails and removed The CI failed When GH Actions fails Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Aug 29, 2023

JoshuaKGoldberg mentioned this pull request Aug 30, 2023

Formatted types/r* packages with dprint #66539

Merged

typescript-bot added the Abandoned This PR had no activity for a long time, and is considered abandoned label Sep 4, 2023

typescript-bot closed this Sep 12, 2023

jakebailey reopened this Sep 12, 2023

typescript-bot removed the Abandoned This PR had no activity for a long time, and is considered abandoned label Sep 12, 2023

johnnyreilly approved these changes Sep 26, 2023

View reviewed changes

typescript-bot added the Maintainer Approved label Sep 26, 2023

sandersn approved these changes Sep 26, 2023

View reviewed changes

sandersn merged commit a8a179c into DefinitelyTyped:master Sep 26, 2023

JoshuaKGoldberg deleted the dprint-react branch September 26, 2023 13:52

ekwoka mentioned this pull request Oct 1, 2023

📝 Improves Documentation of Alpine Methods #66890

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[react] ran dprint fmt #66352

[react] ran dprint fmt #66352

Uh oh!

JoshuaKGoldberg commented Aug 11, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Aug 11, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Aug 11, 2023

Uh oh!

Uh oh!

typescript-bot commented Aug 11, 2023

Uh oh!

typescript-bot commented Aug 29, 2023

Uh oh!

typescript-bot commented Aug 29, 2023

Uh oh!

typescript-bot commented Aug 29, 2023

Uh oh!

typescript-bot commented Sep 4, 2023

Uh oh!

typescript-bot commented Sep 12, 2023

Uh oh!

jakebailey commented Sep 12, 2023

Uh oh!

DangerBotOSS commented Sep 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[react] ran dprint fmt #66352

[react] ran dprint fmt #66352

Uh oh!

Conversation

JoshuaKGoldberg commented Aug 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Footnotes

Uh oh!

typescript-bot commented Aug 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1 package in this PR

Code Reviews

Status

Uh oh!

typescript-bot commented Aug 11, 2023

Uh oh!

Uh oh!

typescript-bot commented Aug 11, 2023

Uh oh!

typescript-bot commented Aug 29, 2023

Uh oh!

typescript-bot commented Aug 29, 2023

Uh oh!

typescript-bot commented Aug 29, 2023

Uh oh!

typescript-bot commented Sep 4, 2023

Uh oh!

typescript-bot commented Sep 12, 2023

Uh oh!

jakebailey commented Sep 12, 2023

Uh oh!

DangerBotOSS commented Sep 12, 2023

react (unpkg)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JoshuaKGoldberg commented Aug 11, 2023 •

edited

Loading

typescript-bot commented Aug 11, 2023 •

edited

Loading

react (`unpkg`)