[selenium-webdriver] ran dprint fmt #66350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@JoshuaKGoldberg Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66350,
"author": "JoshuaKGoldberg",
"headCommitOid": "4ed948f776725f3109a64369af99b2a5a78cf308",
"mergeBaseOid": "77fd45a8acc24b0134624306b279fa45cdec09b3",
"lastPushDate": "2023-08-11T18:21:29.000Z",
"lastActivityDate": "2023-08-24T16:11:56.000Z",
"mergeOfferDate": "2023-08-23T17:34:28.000Z",
"mergeRequestDate": "2023-08-24T16:11:56.000Z",
"mergeRequestUser": "JoshuaKGoldberg",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": true,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "selenium-webdriver",
"kind": "edit",
"files": [
{
"path": "types/selenium-webdriver/chrome.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/devtools/networkinterceptor.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/edge.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/firefox.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/http.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/ie.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/index.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/lib/by.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/lib/capabilities.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/lib/input.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/lib/select.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/lib/session.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/lib/virtual_authenticator.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/remote.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/safari.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/test/chrome.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/test/edge.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/test/firefox.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/test/ie.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/test/index.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/test/remote.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/test/select.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/test/session.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/test/util.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/test/virtual_authenticator.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/v2/chrome.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v2/http.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v2/index.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v2/remote.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v2/safari.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v2/test/chrome.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/v2/test/firefox.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/v2/test/index.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/v2/test/remote.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/v3/chrome.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v3/firefox.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v3/http.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v3/index.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v3/remote.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v3/safari.d.ts",
"kind": "definition"
},
{
"path": "types/selenium-webdriver/v3/test/chrome.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/v3/test/firefox.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/v3/test/index.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/v3/test/remote.ts",
"kind": "test"
},
{
"path": "types/selenium-webdriver/v3/test/testing.ts",
"kind": "test"
}
],
"owners": [
"BillArmstrong",
"Kuniwak",
"cnishina",
"SupernaviX",
"bendxn",
"oddui",
"beta-vulgaris",
"Dzenly",
"AutomatedTester",
"1pete",
"SinghHrmn",
"shubhsheth"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "andrewbranch",
"date": "2023-08-23T17:33:44.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "AutomatedTester",
"date": "2023-08-12T20:21:26.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "shubhsheth",
"date": "2023-08-12T17:08:01.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "SupernaviX",
"date": "2023-08-12T14:20:27.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1675194102,
"ciResult": "pass"
} |
Contributor
|
🔔 @BillArmstrong @Kuniwak @cnishina @SupernaviX @bendxn @oddui @beta-vulgaris @Dzenly @AutomatedTester @1pete @SinghHrmn @shubhsheth — please review this PR in the next few days. Be sure to explicitly select |
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. selenium-webdriver (unpkg)was missing the following properties:
|
SupernaviX
approved these changes
Aug 12, 2023
shubhsheth
approved these changes
Aug 12, 2023
AutomatedTester
approved these changes
Aug 12, 2023
Contributor
|
Re-ping @BillArmstrong, @Kuniwak, @cnishina, @bendxn, @oddui, @beta-vulgaris, @Dzenly, @1pete, @SinghHrmn: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
andrewbranch
approved these changes
Aug 23, 2023
Contributor
|
@JoshuaKGoldberg: Everything looks good here. I am ready to merge this PR (at 4ed948f) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@BillArmstrong, @Kuniwak, @cnishina, @SupernaviX, @bendxn, @oddui, @beta-vulgaris, @Dzenly, @AutomatedTester, @1pete, @SinghHrmn, @shubhsheth: you can do this too.) |
Collaborator
Author
|
Ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hi! This PR is meant to let you know that we're going to be applying formatting automatically to all DefinitelyTyped packages1. This PR is split out of:
This package is particularly huge (>1MB), so we're tagging you in an individual PR as a heads up. Please post here to let us know if you have any workflow needs that auto-formatting might disrupt2.
Cheers! 💖
Footnotes
Note that formatting will be applied as a commit to
masterafter each PR. PRs won't be blocked on any CI check for proper formatting. See Using a formatter for formatting (instead of lint rules) #65993 for more information. ↩For example, if this package is fully auto-generated (rather than manually edited), subsequent PRs might have a lot of noise from formatting differences. We can exclude it from formatting in that case. ↩