[titanium] ran dprint fmt #66349
[titanium] ran dprint fmt #66349
Conversation
|
@JoshuaKGoldberg Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66349,
"author": "JoshuaKGoldberg",
"headCommitOid": "c38f769b9de3fbc02dfb8a118f1581f33e096ec9",
"mergeBaseOid": "77fd45a8acc24b0134624306b279fa45cdec09b3",
"lastPushDate": "2023-08-11T18:21:28.000Z",
"lastActivityDate": "2023-08-26T16:44:28.000Z",
"mergeOfferDate": "2023-08-26T00:23:48.000Z",
"mergeRequestDate": "2023-08-26T16:44:28.000Z",
"mergeRequestUser": "JoshuaKGoldberg",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": true,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "titanium",
"kind": "edit",
"files": [
{
"path": "types/titanium/console.d.ts",
"kind": "definition"
},
{
"path": "types/titanium/globals.d.ts",
"kind": "definition"
},
{
"path": "types/titanium/index.d.ts",
"kind": "definition"
},
{
"path": "types/titanium/titanium-tests.ts",
"kind": "test"
}
],
"owners": [
"appcelerator",
"janvennemann",
"drauggres",
"ffMathy"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "janvennemann",
"date": "2023-08-26T00:23:02.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1675194101,
"ciResult": "pass"
} |
|
🔔 @appcelerator @janvennemann @drauggres @ffMathy — please review this PR in the next few days. Be sure to explicitly select |
|
Re-ping @appcelerator, @janvennemann, @drauggres, @ffMathy: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
janvennemann
left a comment
There was a problem hiding this comment.
Looks good, this shouldn't be an issue for us. Although the types are generated it's no problem at all to run them through a formatter before submitting a PR.
|
@JoshuaKGoldberg: Everything looks good here. I am ready to merge this PR (at c38f769) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@appcelerator, @janvennemann, @drauggres, @ffMathy: you can do this too.) |
|
Ready to merge |
👋 Hi! This PR is meant to let you know that we're going to be applying formatting automatically to all DefinitelyTyped packages1. This PR is split out of:
This package is particularly huge (>1MB), so we're tagging you in an individual PR as a heads up. Please post here to let us know if you have any workflow needs that auto-formatting might disrupt2.
Cheers! 💖
Footnotes
Note that formatting will be applied as a commit to
masterafter each PR. PRs won't be blocked on any CI check for proper formatting. See Using a formatter for formatting (instead of lint rules) #65993 for more information. ↩For example, if this package is fully auto-generated (rather than manually edited), subsequent PRs might have a lot of noise from formatting differences. We can exclude it from formatting in that case. ↩