[node] adds "type" to test runner event details #66282
Conversation
|
@philnash Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66282,
"author": "philnash",
"headCommitOid": "fac7aeaa7b1870f9cabda0ba349a3049ac1e3c6c",
"mergeBaseOid": "0c7f509c8e4b5c3f599ef38b32738dea3f2c79ba",
"lastPushDate": "2023-08-04T06:48:47.000Z",
"lastActivityDate": "2023-08-11T01:19:40.000Z",
"mergeOfferDate": "2023-08-10T21:00:33.000Z",
"mergeRequestDate": "2023-08-11T01:19:40.000Z",
"mergeRequestUser": "philnash",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/test.ts",
"kind": "test"
},
{
"path": "types/node/ts4.8/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/ts4.8/test/test.ts",
"kind": "test"
},
{
"path": "types/node/v18/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/test/test.ts",
"kind": "test"
},
{
"path": "types/node/v18/ts4.8/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/test/test.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"DefinitelyTyped",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"n-e",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2023-08-10T20:59:50.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "Semigradsky",
"date": "2023-08-10T07:00:54.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "atlowChemi",
"date": "2023-08-07T15:39:05.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1665098746,
"ciResult": "pass"
} |
|
🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
358bd51 to
77c6dde
Compare
|
@philnash The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
In [version 20.0.0 (and backported to 19.9.0 and 18.7.0)](nodejs/node#47094) the test runner started reporting on whether a test was a suite. This was exposed to reporters in the `details` object of a `test:pass` or `test:fail` event but this hasn't been documented. This adds the `type` property to both event's `details` object.
77c6dde to
fac7aea
Compare
|
@atlowChemi Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
atlowChemi
left a comment
There was a problem hiding this comment.
Don't have the permission required to approve, but LGTM 🙂
|
@philnash: Everything looks good here. I am ready to merge this PR (at fac7aea) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: you can do this too.) |
|
Ready to merge |
In version 20.0.0 (and backported to 19.9.0 and 18.7.0) the test runner started reporting on whether a test was a suite. This was exposed to reporters in the
detailsobject of atest:passortest:failevent but this hasn't been documented. This adds thetypeproperty to both event'sdetailsobject.This isn't currently documented in Node, but I have opened a PR for it here.
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition: