Skip to content

Formatted types/a* packages with dprint #66238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sandersn merged 57 commits into from
Sep 22, 2023
Merged

Formatted types/a* packages with dprint #66238

sandersn merged 57 commits into from
Sep 22, 2023

Conversation

@JoshuaKGoldberg
Copy link
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 31, 2023 •
edited
Loading

👉 Partial implementation of #65993. If you're seeing this and are surprised it's happening, please read the discussion and give feedback! ❤️

Implements the dprint formatting changes packages whose names start with a. We're splitting up the changes to make it a bit easier to apply & review them en masse - and, if we need later on, revert / bisect for issues. These changes generated with roughly:

git checkout dprint-onboarding -- .dprint.jsonc
time npx dprint fmt "types/a*/**/*.t*"
# Formatted 1204 files.
# npx dprint fmt "types/a*/**/*.t*"  8.76s user 1.04s system 312% cpu 3.136 total
rm .dprint.jsonc

CI failures are due to DefinitelyTyped-tools > feat: remove formatting rules rules from dtslint not being merged included in CI yet.

Includes:

@kachkaev
Copy link
Contributor

kachkaev commented Aug 1, 2023 •
edited
Loading

👋 @JoshuaKGoldberg! TypeScript repo itself uses double quotes:
https://github.com/microsoft/TypeScript

Prettier defaults to double quotes too (I know it’s not used, just giving some context).

Given the above and the number of conversions from " to ', WDYT of using double quotes instead?

If you are interested in seeing opinions on pros and cons of each choice, here is a rather comprehensive discussion thread: prettier/prettier#4102

UPD: I created a thread for replies to avoid discussion mixing: #66238 (comment)

kachkaev
kachkaev reviewed Aug 1, 2023
View reviewed changes
kachkaev
kachkaev reviewed Aug 1, 2023
View reviewed changes
kachkaev
kachkaev reviewed Aug 1, 2023
View reviewed changes
jakebailey
jakebailey reviewed Aug 2, 2023
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg changed the title [WIP] Formatted types/a* packages with dprint Formatted types/a* packages with dprint Aug 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review August 30, 2023 13:27
@JoshuaKGoldberg
Copy link
Collaborator Author

JoshuaKGoldberg commented Aug 30, 2023 •
edited
Loading

Closing & reopening to try to get a dtslint version that doesn't run formatting rules... ✔️

@peterblazejewicz
Copy link
Member

peterblazejewicz commented Sep 2, 2023

just a bump, in case it got lost in other PRs

@JoshuaKGoldberg
Copy link
Collaborator Author

JoshuaKGoldberg commented Sep 2, 2023

Yes! Still on the radar. I touched up a good number of the open PRs this morning and all but two had existing/external failures. So I think I'm going to focus on fixing those up separately in parallel.

@sandersn sandersn merged commit b969f89 into DefinitelyTyped:master Sep 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the dprint-fmt-a branch September 22, 2023 18:07
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakebailey jakebailey jakebailey left review comments

@peterblazejewicz peterblazejewicz peterblazejewicz approved these changes

@sandersn sandersn sandersn approved these changes

@johnnyreilly johnnyreilly johnnyreilly approved these changes

@Diullei Diullei Awaiting requested review from Diullei Diullei is a code owner

@vvakame vvakame Awaiting requested review from vvakame vvakame is a code owner

@Igorbek Igorbek Awaiting requested review from Igorbek Igorbek is a code owner

@horiuchi horiuchi Awaiting requested review from horiuchi horiuchi is a code owner

@eps1lon eps1lon Awaiting requested review from eps1lon eps1lon is a code owner

@borisyankov borisyankov Awaiting requested review from borisyankov borisyankov is a code owner

+1 more reviewer

@kachkaev kachkaev kachkaev left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JoshuaKGoldberg @kachkaev @peterblazejewicz @sandersn @johnnyreilly @jakebailey