Add types for cypress-cdp#66237
Add types for cypress-cdp#66237typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom froissant:master
Conversation
|
@froissant Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66237,
"author": "froissant",
"headCommitOid": "0bc93f39598941b469e8294808d6bbe62acf907e",
"mergeBaseOid": "27c92742527659cd443772444f00258dd518b4da",
"lastPushDate": "2023-07-31T17:18:05.000Z",
"lastActivityDate": "2023-08-01T19:38:58.000Z",
"mergeOfferDate": "2023-08-01T19:33:06.000Z",
"mergeRequestDate": "2023-08-01T19:38:58.000Z",
"mergeRequestUser": "froissant",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "cypress-cdp",
"kind": "add",
"files": [
{
"path": "types/cypress-cdp/cypress-cdp-tests.ts",
"kind": "test"
},
{
"path": "types/cypress-cdp/index.d.ts",
"kind": "definition"
},
{
"path": "types/cypress-cdp/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/cypress-cdp/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/cypress-cdp/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"froissant",
"LouisLoiseau"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2023-08-01T19:32:21.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1658817257,
"ciResult": "pass"
} |
|
🔔 @froissant — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
@froissant The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@froissant: Everything looks good here. I am ready to merge this PR (at 0bc93f3) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
Add types for cypress-cdp.
npm test <package to test>.Adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould contain{ "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.See bahmutov/cypress-cdp#27