Fix css-font-loading-module types for TS 5.0 beta #64014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type of `FontFace.display` is now a union of allowed literals instead of `string`. The new code won't succeed until tomorrow. See microsoft/TypeScript#52328
Contributor
|
@sandersn Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 64014,
"author": "sandersn",
"headCommitOid": "e13c9edf484c1a6fbcc62ccc200df50bc947bd11",
"mergeBaseOid": "a6b57ed5f511b6d1c842b6acb4961c966d4afb00",
"lastPushDate": "2023-01-21T00:25:46.000Z",
"lastActivityDate": "2023-01-23T15:48:52.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "css-font-loading-module",
"kind": "edit",
"files": [
{
"path": "types/css-font-loading-module/index.d.ts",
"kind": "definition"
}
],
"owners": [
"slikts"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [],
"mainBotCommentID": 1399098708,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/e13c9edf484c1a6fbcc62ccc200df50bc947bd11/checks?check_suite_id=10499017080"
} |
Contributor
|
🔔 @slikts — please review this PR in the next few days. Be sure to explicitly select |
Contributor
|
@sandersn The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of
FontFace.displayis now a union of allowed literals instead ofstring.The new code won't succeed until tomorrow. See microsoft/TypeScript#52328