Fix eventsource DOM shim for TS 5.0 beta #64013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The types that the DOM monkeypatch shims are now the precise literals instead of number. The new code won't succeed until tomorrow. See microsoft/TypeScript#52328
Contributor
|
@sandersn Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 64013,
"author": "sandersn",
"headCommitOid": "dbc128a8563bb6ffd56d646c2b16d79aa6ed3e15",
"mergeBaseOid": "a6b57ed5f511b6d1c842b6acb4961c966d4afb00",
"lastPushDate": "2023-01-21T00:23:36.000Z",
"lastActivityDate": "2023-01-23T15:45:33.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "eventsource",
"kind": "edit",
"files": [
{
"path": "types/eventsource/dom-monkeypatch.d.ts",
"kind": "definition"
},
{
"path": "types/eventsource/index.d.ts",
"kind": "definition"
}
],
"owners": [
"scottleedavis",
"afroozeh",
"snakedrak",
"Akuukis"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [],
"mainBotCommentID": 1399097919,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/dbc128a8563bb6ffd56d646c2b16d79aa6ed3e15/checks?check_suite_id=10498995549"
} |
Contributor
|
🔔 @scottleedavis @afroozeh @SnakeDrak @Akuukis — please review this PR in the next few days. Be sure to explicitly select |
Contributor
|
@sandersn The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
Contributor
|
This shouldn't have been a bugfix release but a minor or major bump This are my errors: node_modules/.pnpm/@types+eventsource@1.1.11/node_modules/@types/eventsource/dom-monkeypatch.d.ts:42:12 - error TS2717: Subsequent property declarations must have the same type. Property 'AT_TARGET' must be of type 'number', but here has type '2'.
42 readonly AT_TARGET: 2;
~~~~~~~~~
node_modules/.pnpm/typescript@4.9.4/node_modules/typescript/lib/lib.dom.d.ts:5221:14
5221 readonly AT_TARGET: number;
~~~~~~~~~
'AT_TARGET' was also declared here.
node_modules/.pnpm/@types+eventsource@1.1.11/node_modules/@types/eventsource/dom-monkeypatch.d.ts:43:12 - error TS2717: Subsequent property declarations must have the same type. Property 'BUBBLING_PHASE' must be of type 'number', but here has type '3'.
43 readonly BUBBLING_PHASE: 3;
~~~~~~~~~~~~~~
node_modules/.pnpm/typescript@4.9.4/node_modules/typescript/lib/lib.dom.d.ts:5222:14
5222 readonly BUBBLING_PHASE: number;
~~~~~~~~~~~~~~
'BUBBLING_PHASE' was also declared here.
node_modules/.pnpm/@types+eventsource@1.1.11/node_modules/@types/eventsource/dom-monkeypatch.d.ts:44:12 - error TS2717: Subsequent property declarations must have the same type. Property 'CAPTURING_PHASE' must be of type 'number', but here has type '1'.
44 readonly CAPTURING_PHASE: 1;
~~~~~~~~~~~~~~~
node_modules/.pnpm/typescript@4.9.4/node_modules/typescript/lib/lib.dom.d.ts:5223:14
5223 readonly CAPTURING_PHASE: number;
~~~~~~~~~~~~~~~
'CAPTURING_PHASE' was also declared here.
node_modules/.pnpm/@types+eventsource@1.1.11/node_modules/@types/eventsource/dom-monkeypatch.d.ts:45:12 - error TS2717: Subsequent property declarations must have the same type. Property 'NONE' must be of type 'number', but here has type '0'.
45 readonly NONE: 0;
~~~~
node_modules/.pnpm/typescript@4.9.4/node_modules/typescript/lib/lib.dom.d.ts:5224:14
5224 readonly NONE: number;
~~~~
'NONE' was also declared here.
Found 4 error(s). |
|
Hopefully we can get this sorted out, as not all projects use TS 5.0. |
|
Yeah, I had issues because of it too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types that the DOM monkeypatch shims are now the precise literals instead of number.
The new code won't succeed until tomorrow. See microsoft/TypeScript#52328