Skip to content

@ember/owner: introduce Resolver type#63057

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
chriskrycho:ember-rfc-821-pt2
Nov 4, 2022
Merged

@ember/owner: introduce Resolver type#63057
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
chriskrycho:ember-rfc-821-pt2

Conversation

@chriskrycho
Copy link
Copy Markdown
Contributor

@chriskrycho chriskrycho commented Nov 2, 2022 •
edited
Loading

Implements the next part of Ember RFC 0821. Compare the PR in the preview types: emberjs/ember.js#20253.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Nov 2, 2022 •
edited
Loading

@chriskrycho Thank you for submitting this PR!

This is a live comment which I will keep updated.

5 packages in this PR

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 63057,
  "author": "chriskrycho",
  "headCommitOid": "e574543eb66e061f649442152f677740a1370e66",
  "mergeBaseOid": "b2b356bc6e108de75960f7ccf9dc2adf38c14ea5",
  "lastPushDate": "2022-11-02T22:50:58.000Z",
  "lastActivityDate": "2022-11-04T16:20:27.000Z",
  "mergeOfferDate": "2022-11-04T14:36:36.000Z",
  "mergeRequestDate": "2022-11-04T16:20:27.000Z",
  "mergeRequestUser": "chriskrycho",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "ember-resolver",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember-resolver/ember-resolver-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ember-resolver/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember-resolver/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "dfreeman",
        "chriskrycho",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__application",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__application/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chriskrycho",
        "dfreeman",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__debug",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__debug/container-debug-adapter.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chriskrycho",
        "dfreeman",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__engine",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__engine/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ember__engine/test/engine.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "chriskrycho",
        "dfreeman",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "ember__owner",
      "kind": "edit",
      "files": [
        {
          "path": "types/ember__owner/ember__owner-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ember__owner/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chriskrycho",
        "dfreeman",
        "jamescdavis",
        "wagenet"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2022-11-04T14:35:50.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "dfreeman",
      "date": "2022-11-03T14:42:26.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1301465848,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Edits multiple packages Author is Owner The author of this PR is a listed owner of the package. labels Nov 2, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Nov 2, 2022

🔔 @dfreeman @jamescdavis @wagenet — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS
Copy link
Copy Markdown

DangerBotOSS commented Nov 2, 2022

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

ember-resolver (unpkg)

was missing the following properties:

  1. name
  2. emberResolverFeatureFlags
  3. init
  4. treeForAddon
  5. included
as well as these 1 other properties...

monkeyPatchVendorFiles

Generated by 🚫 dangerJS against e574543

@chriskrycho chriskrycho mentioned this pull request Nov 2, 2022
Merged
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Nov 3, 2022
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Nov 4, 2022
@chriskrycho
Copy link
Copy Markdown
Contributor Author

chriskrycho commented Nov 4, 2022

Ready to merge

@typescript-bot typescript-bot merged commit d5de8b1 into DefinitelyTyped:master Nov 4, 2022
@mileszim
Copy link
Copy Markdown

mileszim commented Nov 10, 2022

@chriskrycho I'm getting this on app builds with the new types

node_modules/@types/ember-resolver/index.d.ts:11:10 - error TS2614: Module '"@ember/owner"' has no exported member 'Resolver'. Did you mean to use 'import Resolver from "@ember/owner"' instead?

11 import { Resolver } from '@ember/owner';
            ~~~~~~~~

@chriskrycho
Copy link
Copy Markdown
Contributor Author

chriskrycho commented Nov 10, 2022

When you say "with the new types" do you mean @types/ember__owner or do you mean the Ember preview types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandersn sandersn sandersn approved these changes

+1 more reviewer

@dfreeman dfreeman dfreeman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Author is Owner The author of this PR is a listed owner of the package. Edits multiple packages Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chriskrycho @typescript-bot @DangerBotOSS @mileszim @dfreeman @sandersn