@falsandtru Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• node — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 62729,
  "author": "falsandtru",
  "headCommitOid": "387f4e82dd59b3659c6d46be8df9f12ed3a129dc",
  "mergeBaseOid": "eb3f30334bbee8b48e3125d779441eec070a3132",
  "lastPushDate": "2022-10-15T04:33:33.000Z",
  "lastActivityDate": "2022-10-18T20:06:21.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/buffer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/dom-events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/node-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/buffer.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/dom-events.ts",
          "kind": "test"
        },
        {
          "path": "types/node/ts4.8/buffer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/ts4.8/dom-events.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1279166125,
  "ciResult": "pass"
}

🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@falsandtru The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Recent change's definitions are impossible in TS4.9.

2022-10-14T15:45:02.1120294Z 2> Error: Errors in typescript@4.9 for external dependencies:
2022-10-14T15:45:02.1151913Z ##[error]2> ../node/buffer.d.ts(2242,19): error TS2310: Type 'Blob' recursively references itself as a base type.
2022-10-14T15:45:02.1161933Z ##[error]2> ../node/dom-events.d.ts(107,15): error TS2310: Type 'Event' recursively references itself as a base type.
2022-10-14T15:45:02.1163230Z ##[error]2> ../node/dom-events.d.ts(119,15): error TS2310: Type 'EventTarget' recursively references itself as a base type.

Why npm test node returns no error although ci failed.

@eps1lon @peterblazejewicz this fix must be shipped right now.

@falsandtru The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@peterblazejewicz Hey this fix must be shipped right now!

@falsandtru it’s being worked on.

@andrewbranch I didn't know that because I got no response. Anyway this serious bug needs to be addressed as a priority.

@falsandtru thanks for your feedback here, the issue is also discussed (and reviewed) in #62759

@peterblazejewicz Can you merge and ship?

See the references in #62729 (reference) #62729 (reference). Many dependent products have broken. Can you understand why the fix should be shipped immediately?

@falsandtru needs to chill.
Given the previous version is working, you can roll back to the last working version by setting resolutions field in package managers.
Having a proper solution takes time, but it's better than "immediately" releasing another improper solution.

@yoursunny You fail to understand that the fix won't break any more, and reviewing this tiny patch is very easy.

Fixing this is a priority. The worst thing we can do in a situation like this is ship an incorrect or incomplete fix and increase the churn and confusion. In the meantime, anyone who is broken can pin their version of @types/node. Nobody is going to rush to merge anything without a full understanding of the problem, the fix, and proper test coverage. We’re working with the author of the original PR and putting up a fix now. It might end up being the same as the fix you have here; I don’t know.

In the future, if you want to help expedite getting a fix out, it’s really important to communicate the full context of the bug and the fix, and to try to do so politely and without hounding contributors and maintainers (especially the non-Microsoft volunteers, because we really value their help and want them to continue helping out). Please give us another hour or so of your patience.

Please give us another hour or so of your patience.

OK, the status of the response was clarified for the first time. However, if you had been more careful, you would have started four days earlier.

pending review after #62782

Superseded by #62782