@voxpelli Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• verror — on npm, on unpkg
  • Config files to check:
    • verror/tsconfig.json: not the expected form and not moving towards it (check: compilerOptions.lib.1, compilerOptions.lib.2)

Code Reviews

Because this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ A DT maintainer needs to approve changes which affect module config files

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 61199,
  "author": "voxpelli",
  "headCommitOid": "5d2c36c65a874d35576740c0f02931b33736ecab",
  "mergeBaseOid": "e72ad742bdc332ce49ecac24b81a2c9636835e98",
  "lastPushDate": "2022-07-12T13:28:16.000Z",
  "lastActivityDate": "2022-07-20T01:52:27.000Z",
  "mergeOfferDate": "2022-07-19T23:43:06.000Z",
  "mergeRequestDate": "2022-07-20T01:52:27.000Z",
  "mergeRequestUser": "voxpelli",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "verror",
      "kind": "edit",
      "files": [
        {
          "path": "types/verror/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/verror/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it (check: `compilerOptions.lib.1`, `compilerOptions.lib.2`)"
        }
      ],
      "owners": [
        "svi3c",
        "max4t"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "RyanCavanaugh",
      "date": "2022-07-19T23:42:23.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1181728145,
  "ciResult": "pass"
}

Hey @voxpelli,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

🔔 @svi3c @max4t — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

I'm not sure what to do about this Config files to check:

verror/tsconfig.json: not the expected form and not moving towards it (check: compilerOptions.lib.1, compilerOptions.lib.2)

The es2022.error is what this definition needs to be compatible with. The es2021.promise is a dependency of es2022.error.

@voxpelli: Everything looks good here. I am ready to merge this PR (at 5d2c36c) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@svi3c, @max4t: you can do this too.)

Ready to merge