Add type for convert-array-to-csv #61079
Conversation
|
@Qiming-Liu Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 61079,
"author": "Qiming-Liu",
"headCommitOid": "b40db7ff2bfb81a2e4e47cbfe2e3310fca944d3e",
"mergeBaseOid": "d8936bce21f5d584ae5671c969153c77aaa6a2ad",
"lastPushDate": "2022-07-04T12:14:52.000Z",
"lastActivityDate": "2022-07-04T21:02:51.000Z",
"mergeOfferDate": "2022-07-04T19:56:51.000Z",
"mergeRequestDate": "2022-07-04T21:02:51.000Z",
"mergeRequestUser": "Qiming-Liu",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "convert-array-to-csv",
"kind": "add",
"files": [
{
"path": "types/convert-array-to-csv/convert-array-to-csv-tests.ts",
"kind": "test"
},
{
"path": "types/convert-array-to-csv/index.d.ts",
"kind": "definition"
},
{
"path": "types/convert-array-to-csv/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/convert-array-to-csv/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"Qiming-Liu"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2022-07-04T19:56:05.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1173757210,
"ciResult": "pass"
} |
|
🔔 @Qiming-Liu — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
peterblazejewicz
left a comment
There was a problem hiding this comment.
LGTM!
@Qiming-Liu thanks!
|
@Qiming-Liu: Everything looks good here. I am ready to merge this PR (at b40db7f) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
Please fill in this template.
npm test <package to test>.If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould contain{ "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.